You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by Jacques Le Roux <ja...@les7arts.com> on 2020/06/07 15:52:25 UTC

OFBIZ-8459 and plugins as a submodule

Hi,

While checking OFBIZ-11745, I found several commits done with OFBIZ-8459 where the plugins dir was successively added, reverted and added again as a 
submodule of ofbiz-framework.
https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b39c179
https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3a4d22
https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bda6192

I guess we all missed it and have removed it. I'd like to know if we all agree that plugins dir is not a submodule of ofbiz-framework.

Thanks

Jacques

Re: OFBIZ-8459 and plugins as a submodule

Posted by Aditya Sharma <ad...@apache.org>.
>> I'd like to know if we all agree that plugins dir is not a submodule of
ofbiz-framework.
+1

Thanks and Regards,
Aditya Sharma

On Mon, Jun 8, 2020 at 5:19 PM Olivier Heintz <ho...@ofbizextra.org>
wrote:

> +1 for plugins dir is not a submodule of ofbiz-framework
>
> Le 07/06/2020 à 17:52, Jacques Le Roux a écrit :
> > Hi,
> >
> > While checking OFBIZ-11745, I found several commits done with OFBIZ-8459
> where the plugins dir was successively added, reverted and added again as a
> > submodule of ofbiz-framework.
> > https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b39c179
> > https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3a4d22
> > https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bda6192
> >
> > I guess we all missed it and have removed it. I'd like to know if we all
> agree that plugins dir is not a submodule of ofbiz-framework.
> >
> > Thanks
> >
> > Jacques
> >
> >
>

Re: OFBIZ-8459 and plugins as a submodule

Posted by Olivier Heintz <ho...@ofbizextra.org>.
+1 for plugins dir is not a submodule of ofbiz-framework

Le 07/06/2020 à 17:52, Jacques Le Roux a écrit :
> Hi,
> 
> While checking OFBIZ-11745, I found several commits done with OFBIZ-8459 where the plugins dir was successively added, reverted and added again as a 
> submodule of ofbiz-framework.
> https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=b39c179
> https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=3a4d22
> https://gitbox.apache.org/repos/asf?p=ofbiz-framework.git;h=bda6192
> 
> I guess we all missed it and have removed it. I'd like to know if we all agree that plugins dir is not a submodule of ofbiz-framework.
> 
> Thanks
> 
> Jacques
> 
>