[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1418: feat(new_metrics): migrate built-in server-level metrics

["empiredan (via GitHub)" <gi...@apache.org>]

empiredan commented on code in PR #1418:
URL: https://github.com/apache/incubator-pegasus/pull/1418#discussion_r1150468952


##########
src/utils/builtin_metrics.h:
##########
@@ -15,19 +15,35 @@
 // specific language governing permissions and limitations
 // under the License.
 
-#include "perf_counter_wrapper.h"
+#pragma once
+
+#include <memory>
+
+#include "utils/metrics.h"
+#include "utils/ports.h"
 #include "utils/singleton.h"
 
 namespace dsn {
-class builtin_counters : public dsn::utils::singleton<builtin_counters>
+
+class builtin_metrics : public utils::singleton<builtin_metrics>

Review Comment:
   OK, I'll use member instead of singleton. Since in most cases an instance is started as a meta server or a replica server, in fact there tends to be an object for `builtin_metrics`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org