You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/08/14 14:26:29 UTC

[GitHub] [dubbo-go] Mulavar opened a new pull request #1378: [WIP]feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5

Mulavar opened a new pull request #1378:
URL: https://github.com/apache/dubbo-go/pull/1378


   <!--  Thanks for sending a pull request!
   Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
   -->
   
   **What this PR does**:
   
   **Which issue(s) this PR fixes**:
   <!--
   *Automatically closes linked issue when PR is merged.
   Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
   _If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
   -->
   Fixes #
   
   **Special notes for your reviewer**:
   
   **Does this PR introduce a user-facing change?**:
   <!--
   If no, just write "NONE" in the release-note block below.
   If yes, a release note is required:
   Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
   -->
   ```release-note
   
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1378: feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1378:
URL: https://github.com/apache/dubbo-go/pull/1378#issuecomment-898903248


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1378](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0e705e5) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.55%`.
   > The diff coverage is `61.76%`.
   
   > :exclamation: Current head 0e705e5 differs from pull request most recent head cda10ba. Consider uploading reports for the commit cda10ba to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1378/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1378      +/-   ##
   ==========================================
   - Coverage   58.07%   55.52%   -2.56%     
   ==========================================
     Files         275      276       +1     
     Lines       13381    15941    +2560     
   ==========================================
   + Hits         7771     8851    +1080     
   - Misses       4650     6154    +1504     
   + Partials      960      936      -24     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
   | [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
   | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `71.87% <0.00%> (-17.79%)` | :arrow_down: |
   | [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `51.64% <0.00%> (+2.31%)` | :arrow_up: |
   | [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `64.15% <0.00%> (+13.03%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
   | [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `55.69% <0.00%> (+2.69%)` | :arrow_up: |
   | [remoting/etcdv3/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2ZhY2FkZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | ... and [308 more](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e3d0ae9...cda10ba](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1378: [WIP]feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1378:
URL: https://github.com/apache/dubbo-go/pull/1378#issuecomment-898903248






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1378: [WIP]feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1378:
URL: https://github.com/apache/dubbo-go/pull/1378#issuecomment-898903248


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1378](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33947b3) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.52%`.
   > The diff coverage is `61.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1378/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1378      +/-   ##
   ==========================================
   - Coverage   58.07%   55.55%   -2.53%     
   ==========================================
     Files         275      276       +1     
     Lines       13381    15941    +2560     
   ==========================================
   + Hits         7771     8856    +1085     
   - Misses       4650     6146    +1496     
   + Partials      960      939      -21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
   | [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
   | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `62.50% <0.00%> (-27.16%)` | :arrow_down: |
   | [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `51.64% <0.00%> (+2.31%)` | :arrow_up: |
   | [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `64.15% <0.00%> (+13.03%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
   | [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `55.69% <0.00%> (+2.69%)` | :arrow_up: |
   | [remoting/etcdv3/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2ZhY2FkZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | ... and [308 more](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e3d0ae9...33947b3](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1378: [WIP]feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1378:
URL: https://github.com/apache/dubbo-go/pull/1378#issuecomment-898903248


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1378](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b065630) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.60%`.
   > The diff coverage is `61.76%`.
   
   > :exclamation: Current head b065630 differs from pull request most recent head 1d112da. Consider uploading reports for the commit 1d112da to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1378/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1378      +/-   ##
   ==========================================
   - Coverage   58.07%   55.47%   -2.61%     
   ==========================================
     Files         275      276       +1     
     Lines       13381    15943    +2562     
   ==========================================
   + Hits         7771     8844    +1073     
   - Misses       4650     6162    +1512     
   + Partials      960      937      -23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
   | [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
   | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `71.87% <0.00%> (-17.79%)` | :arrow_down: |
   | [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `51.64% <0.00%> (+2.31%)` | :arrow_up: |
   | [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `60.37% <0.00%> (+9.26%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
   | [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `55.69% <0.00%> (+2.69%)` | :arrow_up: |
   | [remoting/etcdv3/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2ZhY2FkZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | ... and [307 more](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e3d0ae9...1d112da](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] AlexStocks merged pull request #1378: feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5

Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #1378:
URL: https://github.com/apache/dubbo-go/pull/1378


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1378: [WIP]feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1378:
URL: https://github.com/apache/dubbo-go/pull/1378#issuecomment-898903248


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1378](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b065630) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.60%`.
   > The diff coverage is `61.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1378/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1378      +/-   ##
   ==========================================
   - Coverage   58.07%   55.47%   -2.61%     
   ==========================================
     Files         275      276       +1     
     Lines       13381    15943    +2562     
   ==========================================
   + Hits         7771     8844    +1073     
   - Misses       4650     6162    +1512     
   + Partials      960      937      -23     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
   | [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
   | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `71.87% <0.00%> (-17.79%)` | :arrow_down: |
   | [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `51.64% <0.00%> (+2.31%)` | :arrow_up: |
   | [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `60.37% <0.00%> (+9.26%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
   | [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `55.69% <0.00%> (+2.69%)` | :arrow_up: |
   | [remoting/etcdv3/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2ZhY2FkZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | ... and [307 more](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e3d0ae9...b065630](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] cjphaha commented on a change in pull request #1378: feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5

Posted by GitBox <gi...@apache.org>.
cjphaha commented on a change in pull request #1378:
URL: https://github.com/apache/dubbo-go/pull/1378#discussion_r690973686



##########
File path: remoting/getty/listener.go
##########
@@ -26,11 +26,14 @@ import (
 
 import (
 	"github.com/apache/dubbo-getty"
-	hessian "github.com/apache/dubbo-go-hessian2"
+
+	gxtime "github.com/dubbogo/gost/time"
+
 	perrors "github.com/pkg/errors"
 )
 
 import (
+	hessian "github.com/apache/dubbo-go-hessian2"

Review comment:
       这个 `hessian "github.com/apache/dubbo-go-hessian2"` 是不是应该放在第二个import块会更好一些，因为第三个import块都是`github.com/apache/dubbo-go/ `前缀




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1378: [WIP]feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1378:
URL: https://github.com/apache/dubbo-go/pull/1378#issuecomment-898903248


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1378](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (808bc10) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.57%`.
   > The diff coverage is `61.76%`.
   
   > :exclamation: Current head 808bc10 differs from pull request most recent head 1d112da. Consider uploading reports for the commit 1d112da to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1378/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1378      +/-   ##
   ==========================================
   - Coverage   58.07%   55.50%   -2.58%     
   ==========================================
     Files         275      276       +1     
     Lines       13381    15943    +2562     
   ==========================================
   + Hits         7771     8849    +1078     
   - Misses       4650     6155    +1505     
   + Partials      960      939      -21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
   | [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
   | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `62.50% <0.00%> (-27.16%)` | :arrow_down: |
   | [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `51.64% <0.00%> (+2.31%)` | :arrow_up: |
   | [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `54.71% <0.00%> (+3.60%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
   | [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `55.69% <0.00%> (+2.69%)` | :arrow_up: |
   | [remoting/etcdv3/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2ZhY2FkZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | ... and [307 more](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e3d0ae9...1d112da](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1378: feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1378:
URL: https://github.com/apache/dubbo-go/pull/1378#issuecomment-898903248


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1378](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33947b3) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.52%`.
   > The diff coverage is `61.76%`.
   
   > :exclamation: Current head 33947b3 differs from pull request most recent head 8e4b81f. Consider uploading reports for the commit 8e4b81f to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1378/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1378      +/-   ##
   ==========================================
   - Coverage   58.07%   55.55%   -2.53%     
   ==========================================
     Files         275      276       +1     
     Lines       13381    15941    +2560     
   ==========================================
   + Hits         7771     8856    +1085     
   - Misses       4650     6146    +1496     
   + Partials      960      939      -21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
   | [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
   | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `62.50% <0.00%> (-27.16%)` | :arrow_down: |
   | [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `51.64% <0.00%> (+2.31%)` | :arrow_up: |
   | [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `64.15% <0.00%> (+13.03%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
   | [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `55.69% <0.00%> (+2.69%)` | :arrow_up: |
   | [remoting/etcdv3/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2ZhY2FkZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | ... and [308 more](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e3d0ae9...8e4b81f](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter commented on pull request #1378: [WIP]feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1378:
URL: https://github.com/apache/dubbo-go/pull/1378#issuecomment-898903248


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1378](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d07457d) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.59%`.
   > The diff coverage is `61.76%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1378/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1378      +/-   ##
   ==========================================
   - Coverage   58.07%   55.47%   -2.60%     
   ==========================================
     Files         275      276       +1     
     Lines       13381    15943    +2562     
   ==========================================
   + Hits         7771     8845    +1074     
   - Misses       4650     6159    +1509     
   + Partials      960      939      -21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
   | [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
   | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `71.87% <0.00%> (-17.79%)` | :arrow_down: |
   | [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `51.64% <0.00%> (+2.31%)` | :arrow_up: |
   | [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `64.15% <0.00%> (+13.03%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
   | [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `55.69% <0.00%> (+2.69%)` | :arrow_up: |
   | [remoting/etcdv3/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2ZhY2FkZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | ... and [307 more](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e3d0ae9...d07457d](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1378: [WIP]feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1378:
URL: https://github.com/apache/dubbo-go/pull/1378#issuecomment-898903248


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1378](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (808bc10) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.57%`.
   > The diff coverage is `61.76%`.
   
   > :exclamation: Current head 808bc10 differs from pull request most recent head 33947b3. Consider uploading reports for the commit 33947b3 to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1378/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1378      +/-   ##
   ==========================================
   - Coverage   58.07%   55.50%   -2.58%     
   ==========================================
     Files         275      276       +1     
     Lines       13381    15943    +2562     
   ==========================================
   + Hits         7771     8849    +1078     
   - Misses       4650     6155    +1505     
   + Partials      960      939      -21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
   | [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
   | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `62.50% <0.00%> (-27.16%)` | :arrow_down: |
   | [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `51.64% <0.00%> (+2.31%)` | :arrow_up: |
   | [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `54.71% <0.00%> (+3.60%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
   | [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `55.69% <0.00%> (+2.69%)` | :arrow_up: |
   | [remoting/etcdv3/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2ZhY2FkZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | ... and [307 more](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e3d0ae9...33947b3](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] cjphaha commented on a change in pull request #1378: feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5

Posted by GitBox <gi...@apache.org>.
cjphaha commented on a change in pull request #1378:
URL: https://github.com/apache/dubbo-go/pull/1378#discussion_r690973686



##########
File path: remoting/getty/listener.go
##########
@@ -26,11 +26,14 @@ import (
 
 import (
 	"github.com/apache/dubbo-getty"
-	hessian "github.com/apache/dubbo-go-hessian2"
+
+	gxtime "github.com/dubbogo/gost/time"
+
 	perrors "github.com/pkg/errors"
 )
 
 import (
+	hessian "github.com/apache/dubbo-go-hessian2"

Review comment:
       这个 `hessian "github.com/apache/dubbo-go-hessian2"` 是不是应该放在第二个import块会更好一些，因为第三个import块都是`github.com/apache/dubbo-go/ `前缀




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo-go] codecov-commenter edited a comment on pull request #1378: feat(getty): upgrade getty version to 1.4.5 for dubbo-go 1.5

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1378:
URL: https://github.com/apache/dubbo-go/pull/1378#issuecomment-898903248


   # [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#1378](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (33947b3) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/467c867e04f7d28308305b7601e391080fa73340?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (467c867) will **decrease** coverage by `2.52%`.
   > The diff coverage is `61.76%`.
   
   > :exclamation: Current head 33947b3 differs from pull request most recent head cda10ba. Consider uploading reports for the commit cda10ba to get more accurate results
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo-go/pull/1378/graphs/tree.svg?width=650&height=150&src=pr&token=dcPE6RyFAL&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@            Coverage Diff             @@
   ##              1.5    #1378      +/-   ##
   ==========================================
   - Coverage   58.07%   55.55%   -2.53%     
   ==========================================
     Files         275      276       +1     
     Lines       13381    15941    +2560     
   ==========================================
   + Hits         7771     8856    +1085     
   - Misses       4650     6146    +1496     
   + Partials      960      939      -21     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [config/config\_loader.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19sb2FkZXIuZ28=) | `43.40% <0.00%> (+4.56%)` | :arrow_up: |
   | [config/provider\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3ZpZGVyX2NvbmZpZy5nbw==) | `62.06% <0.00%> (+7.52%)` | :arrow_up: |
   | [config/reference\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3JlZmVyZW5jZV9jb25maWcuZ28=) | `80.00% <0.00%> (-1.67%)` | :arrow_down: |
   | [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `62.50% <0.00%> (-27.16%)` | :arrow_down: |
   | [registry/consul/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvY29uc3VsL3JlZ2lzdHJ5Lmdv) | `51.64% <0.00%> (+2.31%)` | :arrow_up: |
   | [...gistry/event/protocol\_ports\_metadata\_customizer.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvZXZlbnQvcHJvdG9jb2xfcG9ydHNfbWV0YWRhdGFfY3VzdG9taXplci5nbw==) | `65.78% <ø> (+6.41%)` | :arrow_up: |
   | [registry/kubernetes/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkva3ViZXJuZXRlcy9yZWdpc3RyeS5nbw==) | `64.15% <0.00%> (+13.03%)` | :arrow_up: |
   | [registry/zookeeper/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvem9va2VlcGVyL2xpc3RlbmVyLmdv) | `26.58% <0.00%> (-42.65%)` | :arrow_down: |
   | [remoting/etcdv3/client.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2NsaWVudC5nbw==) | `55.69% <0.00%> (+2.69%)` | :arrow_up: |
   | [remoting/etcdv3/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVtb3RpbmcvZXRjZHYzL2ZhY2FkZS5nbw==) | `0.00% <0.00%> (ø)` | |
   | ... and [308 more](https://codecov.io/gh/apache/dubbo-go/pull/1378/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e3d0ae9...cda10ba](https://codecov.io/gh/apache/dubbo-go/pull/1378?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org