You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/09 08:02:58 UTC
[GitHub] [skywalking-satellite] mrproliu opened a new pull request #74: Support Envoy ALS v2/v3
mrproliu opened a new pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74
Follow https://github.com/apache/skywalking/issues/7774, Support transmit Envoy ALS V2 and V3 protocol.
I found the satellite has the `protobuf` register conflict problem, the `Prometheus fethcer` and `goapi` both need Prometheus metrics protocol, so I use `google.golang.org/protobuf/reflect/protoregistry.conflictPolicy=ignore` to ignore the conflict message. If anyone has another good idea, please let me know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] mrproliu commented on pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#issuecomment-941874093
> Current e2e docker-compose, from my understanding, is just a temporally for this commit only.
Yes, using docker-compose to temporally for this commit.
> Please make decision whether `infra-e2e` enhancement should go first.
I think we could merge this PR first, then I start working on `infra-e2e` kinD environment enhancement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#issuecomment-939254410
If conflict exists, which dependency is being used?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#issuecomment-941865911
> > > > Please copy this test to the main repository, to replace the ALS E2E.
> > >
> > >
> > > >
> > >
> > >
> > > > @kezhenxu94 Please recheck.
> > >
> > >
> > > Ok. Current this E2E is only set up and verify the protocol transmit function, I need to set up a complete environment and add more verify if add to the main repo.
> > > Also, Should I need to include satellite service into the main repo ALS E2E?
> >
> >
> > We should, but let's do that a little late, when we are closing satellite 0.3.0 release. End of this month?
>
> Yes, we could. The 0.3.0 release, will including Envoy Metrics and ALS transmit.
Let's take some time to work on e2e-infra kind(k8s) part. Then we could be more confident to do release for main repo 8.9.0 and satellite 0.3.0. I think it is worth to wait.
Current e2e docker-compose, from my understanding, is just a temporally for this commit only. Please make decision whether `infra-e2e` enhancement should go first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#discussion_r727685609
##########
File path: plugins/receiver/grpc/envoyalsv2/als_service.go
##########
@@ -0,0 +1,63 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package envoyalsv2
+
+import (
+ "io"
+ "time"
+
+ v2 "skywalking.apache.org/repo/goapi/proto/envoy/service/accesslog/v2"
+ v1 "skywalking.apache.org/repo/goapi/satellite/data/v1"
+)
+
+const eventName = "grpc-envoy-als-v2-event"
+
+type AlsService struct {
+ receiveChannel chan *v1.SniffData
+ v2.UnimplementedAccessLogServiceServer
+}
+
+func (m *AlsService) StreamAccessLogs(stream v2.AccessLogService_StreamAccessLogsServer) error {
+ var identifier *v2.StreamAccessLogsMessage_Identifier
+ for {
+ item, err := stream.Recv()
+ if err == io.EOF {
+ return stream.SendAndClose(&v2.StreamAccessLogsResponse{})
+ }
+ if err != nil {
+ return err
+ }
+ // only first item has identifier property
+ // need correlate information to each item
+ if item.Identifier != nil {
+ identifier = item.Identifier
+ }
+ item.Identifier = identifier
Review comment:
Should we consider to package one stream package(all elements) as one message event?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng edited a comment on pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
wu-sheng edited a comment on pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#issuecomment-939261223
@gxthrj said he will, but I didn't see it is coming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] mrproliu commented on pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#issuecomment-939258457
> > If conflict exists, which dependency is being used?
>
> Currently is using `goapi`.
Also, I have a look at the Prometheus fetch plugin, we haven't use the `protobuf` to transmit content. So I think it is safe for now. But we need the E2E for testing the prometheus fetch plugin.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#discussion_r727666644
##########
File path: docs/en/setup/plugins/receiver_grpc-envoyals-v3-receiver.md
##########
@@ -0,0 +1,11 @@
+# Receiver/grpc-envoyals-v3-receiver
Review comment:
Why no `-` between `envoy` and `als`?
##########
File path: plugins/receiver/grpc/envoyalsv2/als_service.go
##########
@@ -0,0 +1,63 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package envoyalsv2
+
+import (
+ "io"
+ "time"
+
+ v2 "skywalking.apache.org/repo/goapi/proto/envoy/service/accesslog/v2"
+ v1 "skywalking.apache.org/repo/goapi/satellite/data/v1"
+)
+
+const eventName = "grpc-envoy-als-v2-event"
+
+type AlsService struct {
+ receiveChannel chan *v1.SniffData
+ v2.UnimplementedAccessLogServiceServer
+}
+
+func (m *AlsService) StreamAccessLogs(stream v2.AccessLogService_StreamAccessLogsServer) error {
+ var identifier *v2.StreamAccessLogsMessage_Identifier
+ for {
+ item, err := stream.Recv()
+ if err == io.EOF {
+ return stream.SendAndClose(&v2.StreamAccessLogsResponse{})
+ }
+ if err != nil {
+ return err
+ }
+ // only first item has identifier property
+ // need correlate information to each item
+ if item.Identifier != nil {
+ identifier = item.Identifier
+ }
+ item.Identifier = identifier
Review comment:
Should we consider to package one stream package(all elements) as one message event?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] mrproliu commented on pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#issuecomment-939255672
> If conflict exists, which dependency is being used?
Currently is using `goapi`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#issuecomment-939395045
> > Please copy this test to the main repository, to replace the ALS E2E.
>
> >
>
> > @kezhenxu94 Please recheck.
>
>
>
> Ok. Current this E2E is only set up and verify the protocol transmit function, I need to set up a complete environment and add more verify if add to the main repo.
>
>
>
> Also, Should I need to include satellite service into the main repo ALS E2E?
We should, but let's do that a little late, when we are closing satellite 0.3.0 release. End of this month?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on a change in pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on a change in pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#discussion_r727666644
##########
File path: docs/en/setup/plugins/receiver_grpc-envoyals-v3-receiver.md
##########
@@ -0,0 +1,11 @@
+# Receiver/grpc-envoyals-v3-receiver
Review comment:
Why no `-` between `envoy` and `als`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] mrproliu commented on a change in pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#discussion_r727676766
##########
File path: docs/en/setup/plugins/receiver_grpc-envoyals-v3-receiver.md
##########
@@ -0,0 +1,11 @@
+# Receiver/grpc-envoyals-v3-receiver
Review comment:
changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] mrproliu commented on a change in pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
mrproliu commented on a change in pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#discussion_r727676766
##########
File path: docs/en/setup/plugins/receiver_grpc-envoyals-v3-receiver.md
##########
@@ -0,0 +1,11 @@
+# Receiver/grpc-envoyals-v3-receiver
Review comment:
changed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] mrproliu commented on pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#issuecomment-939634382
> > > Please copy this test to the main repository, to replace the ALS E2E.
> >
> >
> > >
> >
> >
> > > @kezhenxu94 Please recheck.
> >
> >
> > Ok. Current this E2E is only set up and verify the protocol transmit function, I need to set up a complete environment and add more verify if add to the main repo.
> > Also, Should I need to include satellite service into the main repo ALS E2E?
>
> We should, but let's do that a little late, when we are closing satellite 0.3.0 release. End of this month?
Yes, we could. The 0.3.0 release, will including Envoy Metrics and ALS transmit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] kezhenxu94 commented on a change in pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#discussion_r725557534
##########
File path: go.mod
##########
@@ -20,9 +19,9 @@ require (
go.uber.org/automaxprocs v1.4.0
golang.org/x/mod v0.4.2
golang.org/x/tools v0.1.6 // indirect
- google.golang.org/grpc v1.38.0
- google.golang.org/protobuf v1.27.0
+ google.golang.org/grpc v1.40.0
Review comment:
These version changes are not reflected in license files
##########
File path: test/e2e/case/envoy/e2e.yaml
##########
@@ -0,0 +1,72 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This file is used to show how to write configuration files and can be used to test.
+
+setup:
+ env: compose
+ file: docker-compose.yml
+ timeout: 1200
+ steps:
+ - name: install yq
+ command: |
+ if ! command -v yq &> /dev/null; then
+ mkdir -p /tmp/skywalking-infra-e2e/bin && cd /tmp/skywalking-infra-e2e
+ mkdir -p yq && cd yq
+ curl -kLo yq.tar.gz https://github.com/mikefarah/yq/archive/v4.11.1.tar.gz
+ tar -zxf yq.tar.gz --strip=1
+ go install && go build -ldflags -s && mv yq ../bin/yq
+ export PATH="$PATH:/tmp/skywalking-infra-e2e/bin"
+ echo "success to install yq"
+ fi
+ - name: install swctl
+ command: |
+ if ! command -v swctl &> /dev/null; then
+ mkdir -p /tmp/skywalking-infra-e2e/bin && cd /tmp/skywalking-infra-e2e
+ mkdir -p swctl && cd swctl
+ curl -kLo skywalking-cli.tar.gz https://github.com/apache/skywalking-cli/archive/76f9f848b3142d14c6ab6fa7910d408b92bced64.tar.gz
+ tar -zxf skywalking-cli.tar.gz --strip=1
+ make install DESTDIR=/usr/local/bin
+ echo "success to install swctl"
+ fi
+
+cleanup:
+ # always never success failure
+ on: no
+
+trigger:
+ action: http
+ interval: 3s
+ times: 5
+ url: http://${consumer_host}:${consumer_9090}/info
+ method: POST
+
+verify:
+ # verify with retry strategy
+ retry:
+ # max retry count
+ count: 20
+ # the interval between two retries, in millisecond.
+ interval: 10000
Review comment:
Use 10s
##########
File path: plugins/forwarder/grpc/envoyalsv2/forwarder.go
##########
@@ -0,0 +1,121 @@
+// Licensed to Apache Software Foundation (ASF) under one or more contributor
+// license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright
+// ownership. Apache Software Foundation (ASF) licenses this file to you under
+// the Apache License, Version 2.0 (the "License"); you may
+// not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+
+package envoyalsv2
+
+import (
+ "context"
+ "fmt"
+ "io"
+ "reflect"
+
+ v2 "skywalking.apache.org/repo/goapi/proto/envoy/service/accesslog/v2"
+ v1 "skywalking.apache.org/repo/goapi/satellite/data/v1"
+
+ "google.golang.org/grpc"
+
+ "github.com/apache/skywalking-satellite/internal/pkg/config"
+ "github.com/apache/skywalking-satellite/internal/pkg/log"
+ "github.com/apache/skywalking-satellite/internal/satellite/event"
+)
+
+const Name = "envoyals-v2-grpc-forwarder"
+
+type Forwarder struct {
+ config.CommonFields
+ alsClient v2.AccessLogServiceClient
+}
+
+func (f *Forwarder) Name() string {
+ return Name
+}
+
+func (f *Forwarder) Description() string {
+ return "This is a synchronization ALS v2 grpc forwarder with the Envoy ALS protocol."
+}
+
+func (f *Forwarder) DefaultConfig() string {
+ return ``
+}
+
+func (f *Forwarder) Prepare(connection interface{}) error {
+ client, ok := connection.(*grpc.ClientConn)
+ if !ok {
+ return fmt.Errorf("the %s is only accepet the grpc client, but receive a %s",
Review comment:
```suggestion
return fmt.Errorf("the %s only accepts a grpc client, but received a %s",
```
##########
File path: test/e2e/case/envoy/e2e.yaml
##########
@@ -0,0 +1,72 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+# This file is used to show how to write configuration files and can be used to test.
+
+setup:
+ env: compose
+ file: docker-compose.yml
+ timeout: 1200
+ steps:
+ - name: install yq
+ command: |
+ if ! command -v yq &> /dev/null; then
+ mkdir -p /tmp/skywalking-infra-e2e/bin && cd /tmp/skywalking-infra-e2e
+ mkdir -p yq && cd yq
+ curl -kLo yq.tar.gz https://github.com/mikefarah/yq/archive/v4.11.1.tar.gz
+ tar -zxf yq.tar.gz --strip=1
+ go install && go build -ldflags -s && mv yq ../bin/yq
+ export PATH="$PATH:/tmp/skywalking-infra-e2e/bin"
+ echo "success to install yq"
+ fi
+ - name: install swctl
+ command: |
+ if ! command -v swctl &> /dev/null; then
+ mkdir -p /tmp/skywalking-infra-e2e/bin && cd /tmp/skywalking-infra-e2e
+ mkdir -p swctl && cd swctl
+ curl -kLo skywalking-cli.tar.gz https://github.com/apache/skywalking-cli/archive/76f9f848b3142d14c6ab6fa7910d408b92bced64.tar.gz
+ tar -zxf skywalking-cli.tar.gz --strip=1
+ make install DESTDIR=/usr/local/bin
+ echo "success to install swctl"
+ fi
+
+cleanup:
+ # always never success failure
+ on: no
Review comment:
???
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#issuecomment-939261223
@gxthrg said he will, but I didn't see it is coming.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] wu-sheng commented on pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#issuecomment-941865911
> > > > Please copy this test to the main repository, to replace the ALS E2E.
> > >
> > >
> > > >
> > >
> > >
> > > > @kezhenxu94 Please recheck.
> > >
> > >
> > > Ok. Current this E2E is only set up and verify the protocol transmit function, I need to set up a complete environment and add more verify if add to the main repo.
> > > Also, Should I need to include satellite service into the main repo ALS E2E?
> >
> >
> > We should, but let's do that a little late, when we are closing satellite 0.3.0 release. End of this month?
>
> Yes, we could. The 0.3.0 release, will including Envoy Metrics and ALS transmit.
Let's take some time to work on e2e-infra kind(k8s) part. Then we could be more confident to do release for main repo 8.9.0 and satellite 0.3.0. I think it is worth to wait.
Current e2e docker-compose, from my understanding, is just a temporally for this commit only. Please make decision whether `infra-e2e` enhancement should go first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] mrproliu commented on pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#issuecomment-941874093
> Current e2e docker-compose, from my understanding, is just a temporally for this commit only.
Yes, using docker-compose to temporally for this commit.
> Please make decision whether `infra-e2e` enhancement should go first.
I think we could merge this PR first, then I start working on `infra-e2e` kinD environment enhancement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking-satellite] mrproliu commented on pull request #74: Support Envoy ALS v2/v3
Posted by GitBox <gi...@apache.org>.
mrproliu commented on pull request #74:
URL: https://github.com/apache/skywalking-satellite/pull/74#issuecomment-939383828
> Please copy this test to the main repository, to replace the ALS E2E.
>
> @kezhenxu94 Please recheck.
Ok. Current this E2E is only set up and verify the protocol transmit function, I need to set up a complete environment and add more verify if add to the main repo.
Also, Should I need to include satellite service into the main repo ALS E2E?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org