You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "vincent81jiang (via GitHub)" <gi...@apache.org> on 2023/08/17 20:36:29 UTC
[GitHub] [kafka] vincent81jiang opened a new pull request, #14239: KAFKA-15375: do not write clean shutdown marker file for a log dir if startup has not completed recovering it
vincent81jiang opened a new pull request, #14239:
URL: https://github.com/apache/kafka/pull/14239
When running in kraft mode, LogManager.startup is called in a different thread than the main broker
startup thread (by BrokerMetadataPublisher when the first metadata update is received.) If a fatal
error happens during broker startup, before LogManager.startup is completed, LogManager.shutdown may
mark log dirs as clean shutdown improperly.
This PR includes following change:
1. During LogManager startup time:
- track hadCleanShutdwon info for each log dir
- track loadLogsCompleted status for each log dir
2. During LogManager shutdown time:
- do not write clean shutdown marker file for log dirs which have hadCleanShutdown==false and loadLogsCompleted==false
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] cmccabe merged pull request #14239: KAFKA-15375: do not write clean shutdown marker file for a log dir if startup has not completed recovering it
Posted by "cmccabe (via GitHub)" <gi...@apache.org>.
cmccabe merged PR #14239:
URL: https://github.com/apache/kafka/pull/14239
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] jsancio commented on pull request #14239: KAFKA-15375: do not write clean shutdown marker file for a log dir if startup has not completed recovering it
Posted by "jsancio (via GitHub)" <gi...@apache.org>.
jsancio commented on PR #14239:
URL: https://github.com/apache/kafka/pull/14239#issuecomment-1699559425
Thanks for catching this and fixing it @vincent81jiang . Do you think that this bug fix should be cherry picked to previous releases?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org