[GitHub] carbondata pull request #2589: [WIP][CARBONSTORE] Refactor CarbonStore API

[ajithme <gi...@git.apache.org>]

Github user ajithme commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/2589#discussion_r207501460
  
    --- Diff: store/sdk/src/main/java/org/apache/carbondata/sdk/store/descriptor/ScanDescriptor.java ---
    @@ -15,23 +15,33 @@
      * limitations under the License.
      */
     
    -package org.apache.carbondata.store.api.descriptor;
    +package org.apache.carbondata.sdk.store.descriptor;
     
    +import java.io.DataInput;
    +import java.io.DataOutput;
    +import java.io.IOException;
     import java.util.Objects;
     
    +import org.apache.carbondata.common.annotations.InterfaceAudience;
    +import org.apache.carbondata.common.annotations.InterfaceStability;
     import org.apache.carbondata.core.scan.expression.Expression;
    +import org.apache.carbondata.core.util.ObjectSerializationUtil;
     
    -public class SelectDescriptor {
    +import org.apache.hadoop.io.Writable;
    +
    +@InterfaceAudience.User
    +@InterfaceStability.Evolving
    +public class ScanDescriptor implements Writable {
     
       private TableIdentifier table;
       private String[] projection;
       private Expression filter;
       private long limit;
    --- End diff --
    
    Must be Long.MAX_VALUE


---