You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Riza Suminto (Code Review)" <ge...@cloudera.org> on 2025/04/14 05:15:56 UTC
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Riza Suminto has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22776
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
An equivalent of ImpalaBeeswaxResult.schema is not implemented at
ImpylaHS2ResultSet. However, column_labels and column_types fields are
implemented for both.
This patch remove usage of ImpalaBeeswaxResult.schema and replace it
with either column_labels or column_types field. Tests that used to
access ImpalaBeeswaxResult.schema are migrated to test using hs2
protocol by default. Also fix flake8 issues in modified test files.
Testing:
Run and pass modified test files in exhaustive exploration.
Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
---
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_metadata_no_events_processing.py
M tests/custom_cluster/test_stats_extrapolation.py
M tests/metadata/test_event_processing.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_refresh_partition.py
M tests/metadata/test_stats_extrapolation.py
7 files changed, 52 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/22776/1
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11736/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Apr 2025 15:36:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 7:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18927/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Apr 2025 01:10:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 3:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_metadata_no_events_processing.py
File tests/custom_cluster/test_metadata_no_events_processing.py:
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_metadata_no_events_processing.py@28
PS2, Line 28: def default_test_protocol(cls):
> Are we going to remove this when everything is switched over to HS2?
Yes, that is the plan.
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_stats_extrapolation.py
File tests/custom_cluster/test_stats_extrapolation.py:
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_stats_extrapolation.py@60
PS2, Line 60: col_names = [col_name for col_name in table_stats.column_labels]
> Previously we had a transformation, we called ".upper()" on the name. Do we
Not needed. It is already in uppercase.
https://github.com/apache/impala/blob/50a98dce46fd337461f67b98979fece95c7bf738/tests/common/impala_connection.py#L906
Even in beeswax.
https://github.com/apache/impala/blob/50a98dce46fd337461f67b98979fece95c7bf738/tests/beeswax/impala_beeswax.py#L87
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/metadata/test_stats_extrapolation.py
File tests/metadata/test_stats_extrapolation.py:
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/metadata/test_stats_extrapolation.py@78
PS2, Line 78: create table {0
> Although I find this indentation logical, our style guide says we should us
Done
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/metadata/test_stats_extrapolation.py@147
PS2, Line 147: assert len(actual.column_labels) == len(expected.column_labels)
> Same as before, don't we need the ".upper()' call? If not, we can have
Answered here:
https://gerrit.cloudera.org/c/22776/2/tests/custom_cluster/test_stats_extrapolation.py#60
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Apr 2025 15:04:13 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18922/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Apr 2025 15:39:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 2:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_metadata_no_events_processing.py
File tests/custom_cluster/test_metadata_no_events_processing.py:
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_metadata_no_events_processing.py@28
PS2, Line 28: def default_test_protocol(cls):
Are we going to remove this when everything is switched over to HS2?
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_stats_extrapolation.py
File tests/custom_cluster/test_stats_extrapolation.py:
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_stats_extrapolation.py@60
PS2, Line 60: col_names = [col_name for col_name in table_stats.column_labels]
Previously we had a transformation, we called ".upper()" on the name. Do we not need it anymore?
Do we need to create a new list here, couldn't we have
col_names = table_stats.column_labels
?
AFAICS we're not mutating the list.
Applies also to L66.
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/metadata/test_stats_extrapolation.py
File tests/metadata/test_stats_extrapolation.py:
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/metadata/test_stats_extrapolation.py@78
PS2, Line 78:
Although I find this indentation logical, our style guide says we should use +4 spaces for continuation lines.
Same on L135.
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/metadata/test_stats_extrapolation.py@147
PS2, Line 147: col_names = [col_name for col_name in actual.column_labels]
Same as before, don't we need the ".upper()' call? If not, we can have
col_names = actual.column_labels
.
Applies to L175 too.
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Apr 2025 14:51:31 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18921/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Apr 2025 15:39:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Apr 2025 15:34:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Apr 2025 15:36:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 2:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22776/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22776/1//COMMIT_MSG@13
PS1, Line 13: remove
> nit: removes
Done
http://gerrit.cloudera.org:8080/#/c/22776/1//COMMIT_MSG@13
PS1, Line 13: replac
> nit: replaces
Done
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Apr 2025 14:26:22 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Daniel Becker, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22776
to look at the new patch set (#5).
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
An equivalent of ImpalaBeeswaxResult.schema is not implemented at
ImpylaHS2ResultSet. However, column_labels and column_types fields are
implemented for both.
This patch removes usage of ImpalaBeeswaxResult.schema and replaces it
with either column_labels or column_types field. Tests that used to
access ImpalaBeeswaxResult.schema are migrated to test using hs2
protocol by default. Also fix flake8 issues in modified test files.
Testing:
Run and pass modified test files in exhaustive exploration.
Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
---
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_metadata_no_events_processing.py
M tests/custom_cluster/test_stats_extrapolation.py
M tests/metadata/test_event_processing.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_refresh_partition.py
M tests/metadata/test_stats_extrapolation.py
7 files changed, 53 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/22776/5
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22776
to look at the new patch set (#2).
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
An equivalent of ImpalaBeeswaxResult.schema is not implemented at
ImpylaHS2ResultSet. However, column_labels and column_types fields are
implemented for both.
This patch removes usage of ImpalaBeeswaxResult.schema and replaces it
with either column_labels or column_types field. Tests that used to
access ImpalaBeeswaxResult.schema are migrated to test using hs2
protocol by default. Also fix flake8 issues in modified test files.
Testing:
Run and pass modified test files in exhaustive exploration.
Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
---
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_metadata_no_events_processing.py
M tests/custom_cluster/test_stats_extrapolation.py
M tests/metadata/test_event_processing.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_refresh_partition.py
M tests/metadata/test_stats_extrapolation.py
7 files changed, 52 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/22776/2
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
http://gerrit.cloudera.org:8080/#/c/22776/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/22776/1//COMMIT_MSG@13
PS1, Line 13: replace
nit: replaces
http://gerrit.cloudera.org:8080/#/c/22776/1//COMMIT_MSG@13
PS1, Line 13: remove
nit: removes
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Apr 2025 14:25:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18920/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Apr 2025 15:29:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Daniel Becker, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22776
to look at the new patch set (#3).
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
An equivalent of ImpalaBeeswaxResult.schema is not implemented at
ImpylaHS2ResultSet. However, column_labels and column_types fields are
implemented for both.
This patch removes usage of ImpalaBeeswaxResult.schema and replaces it
with either column_labels or column_types field. Tests that used to
access ImpalaBeeswaxResult.schema are migrated to test using hs2
protocol by default. Also fix flake8 issues in modified test files.
Testing:
Run and pass modified test files in exhaustive exploration.
Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
---
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_metadata_no_events_processing.py
M tests/custom_cluster/test_stats_extrapolation.py
M tests/metadata/test_event_processing.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_refresh_partition.py
M tests/metadata/test_stats_extrapolation.py
7 files changed, 53 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/22776/3
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Daniel Becker, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22776
to look at the new patch set (#7).
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
An equivalent of ImpalaBeeswaxResult.schema is not implemented at
ImpylaHS2ResultSet. However, column_labels and column_types fields are
implemented for both.
This patch removes usage of ImpalaBeeswaxResult.schema and replaces it
with either column_labels or column_types field. Tests that used to
access ImpalaBeeswaxResult.schema are migrated to test using hs2
protocol by default. Also fix flake8 issues in modified test files.
Testing:
Run and pass modified test files in exhaustive exploration.
Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
---
M tests/common/impala_connection.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_metadata_no_events_processing.py
M tests/custom_cluster/test_stats_extrapolation.py
M tests/metadata/test_event_processing.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_refresh_partition.py
M tests/metadata/test_stats_extrapolation.py
8 files changed, 58 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/22776/7
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 7:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22776/7/tests/common/impala_connection.py
File tests/common/impala_connection.py:
http://gerrit.cloudera.org:8080/#/c/22776/7/tests/common/impala_connection.py@958
PS7, Line 958:
: def get_data(self):
: if self.data:
: return '\n'.join(self.data)
: return ''
Implement trivial get_data() method in patch set 7.
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Apr 2025 00:44:23 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 7: Code-Review+2
Carry +2
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Apr 2025 00:45:30 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 7: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Apr 2025 06:28:10 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_stats_extrapolation.py
File tests/custom_cluster/test_stats_extrapolation.py:
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_stats_extrapolation.py@60
PS2, Line 60: col_names = [col_name for col_name in table_stats.column_labels]
> Not needed. It is already in uppercase.
Then do we need to create a new list instead of just doing
col_names = table_stats.column_labels
?
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Apr 2025 15:06:36 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 4:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_stats_extrapolation.py
File tests/custom_cluster/test_stats_extrapolation.py:
http://gerrit.cloudera.org:8080/#/c/22776/2/tests/custom_cluster/test_stats_extrapolation.py@60
PS2, Line 60: col_names = table_stats.column_labels
> Then do we need to create a new list instead of just doing
You're right. Done in patch set 4.
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Apr 2025 15:12:53 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 5:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/22776/4/tests/metadata/test_stats_extrapolation.py
File tests/metadata/test_stats_extrapolation.py:
http://gerrit.cloudera.org:8080/#/c/22776/4/tests/metadata/test_stats_extrapolation.py@176
PS4, Line 176: col_names = actual.column_labels
> Could we also have 'col_names = actual.column_labels' here?
Of course! Done.
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 5
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Apr 2025 15:15:52 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/18901/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 1
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Mon, 14 Apr 2025 05:41:58 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Noemi Pap-Takacs (Code Review)" <ge...@cloudera.org>.
Noemi Pap-Takacs has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Apr 2025 14:47:42 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 6: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/11736/
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 6
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Apr 2025 21:18:45 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
An equivalent of ImpalaBeeswaxResult.schema is not implemented at
ImpylaHS2ResultSet. However, column_labels and column_types fields are
implemented for both.
This patch removes usage of ImpalaBeeswaxResult.schema and replaces it
with either column_labels or column_types field. Tests that used to
access ImpalaBeeswaxResult.schema are migrated to test using hs2
protocol by default. Also fix flake8 issues in modified test files.
Testing:
Run and pass modified test files in exhaustive exploration.
Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Reviewed-on: http://gerrit.cloudera.org:8080/22776
Reviewed-by: Riza Suminto <ri...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M tests/common/impala_connection.py
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_metadata_no_events_processing.py
M tests/custom_cluster/test_stats_extrapolation.py
M tests/metadata/test_event_processing.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_refresh_partition.py
M tests/metadata/test_stats_extrapolation.py
8 files changed, 58 insertions(+), 23 deletions(-)
Approvals:
Riza Suminto: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 8
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Riza Suminto (Code Review)" <ge...@cloudera.org>.
Hello Quanlong Huang, Daniel Becker, Noemi Pap-Takacs, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22776
to look at the new patch set (#4).
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
An equivalent of ImpalaBeeswaxResult.schema is not implemented at
ImpylaHS2ResultSet. However, column_labels and column_types fields are
implemented for both.
This patch removes usage of ImpalaBeeswaxResult.schema and replaces it
with either column_labels or column_types field. Tests that used to
access ImpalaBeeswaxResult.schema are migrated to test using hs2
protocol by default. Also fix flake8 issues in modified test files.
Testing:
Run and pass modified test files in exhaustive exploration.
Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
---
M tests/common/impala_test_suite.py
M tests/custom_cluster/test_metadata_no_events_processing.py
M tests/custom_cluster/test_stats_extrapolation.py
M tests/metadata/test_event_processing.py
M tests/metadata/test_hms_integration.py
M tests/metadata/test_refresh_partition.py
M tests/metadata/test_stats_extrapolation.py
7 files changed, 53 insertions(+), 23 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/76/22776/4
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 4:
(1 comment)
One last place :)
http://gerrit.cloudera.org:8080/#/c/22776/4/tests/metadata/test_stats_extrapolation.py
File tests/metadata/test_stats_extrapolation.py:
http://gerrit.cloudera.org:8080/#/c/22776/4/tests/metadata/test_stats_extrapolation.py@176
PS4, Line 176: col_names = [col_name for col_name in actual.column_labels]
Could we also have 'col_names = actual.column_labels' here?
Thanks.
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 4
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Tue, 15 Apr 2025 15:13:37 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22776 )
Change subject: IMPALA-13961: Remove usage of ImpalaBeeswaxResult.schema
......................................................................
Patch Set 7:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/11739/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/22776
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I060fe2d3cded1470fd09b86675cb22442c19fbee
Gerrit-Change-Number: 22776
Gerrit-PatchSet: 7
Gerrit-Owner: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Noemi Pap-Takacs <np...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 16 Apr 2025 00:45:08 +0000
Gerrit-HasComments: No