[jira] [Commented] (S2GRAPH-44) Provide cache for WhereParser on query.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/S2GRAPH-44?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15158590#comment-15158590 ] 

ASF GitHub Bot commented on S2GRAPH-44:
---------------------------------------

GitHub user SteamShon opened a pull request:

    https://github.com/apache/incubator-s2graph/pull/28

    [S2GRAPH-44] Provide cache for WhereParser on query.

    add RequestCache for WhereParser on Query.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-44

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-s2graph/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #28
    
----
commit b9172cc217e8f75cf037c62adb992f51f8f26a6a
Author: DO YUNG YOON <st...@apache.org>
Date:   2016-02-23T09:09:07Z

    add RequestCache for WhereParser on Query.

----


> Provide cache for WhereParser on query.
> ---------------------------------------
>
>                 Key: S2GRAPH-44
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-44
>             Project: S2Graph
>          Issue Type: Improvement
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>              Labels: Cache, Performance
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Currently, we are building WhereParser on every request and scala parser combinator is notorious for it's slow performance. Actually we don't have to build WhereParser on every request.
> WhereParser is dependent only on Label and where clause string. so I think it is better to provide parser cache with following key. note that Where class do not contain actual data, but expect caller to provide edge to check if given edge should be included or not.
> Key: labelName + where clause string.
> Value: Where class that hold structure for filtering.
> I think this can be important performance improvement and easy to implement.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)