You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "richardfogaca (via GitHub)" <gi...@apache.org> on 2026/04/14 18:38:41 UTC

[PR] fix(dashboard): display control (dynamic group-by) now affects charts [superset]

richardfogaca opened a new pull request, #39354:
URL: https://github.com/apache/superset/pull/39354

   ### SUMMARY
   
   Fixes four independent bugs that caused the **Dynamic Group By** display control to have no visible effect on dashboard charts. When a user selected a column and clicked _Apply Filters_, the chart would either appear unchanged or revert to a previous state.
   
   **Root causes (four independent bugs):**
   
   | Bug | Root Cause | Fix |
   |-----|-----------|-----|
   | A | `processGroupByCustomizations` injected column names as row filter values — `WHERE status IN ('status')` — producing 0 rows | Removed the entire `allFilters` block |
   | B | `buildExistingColumnsSet` added the chart's base `groupby` to the conflict set, so selecting a column already in `groupby` silently no-oped | Removed `existingGroupBy` lines from the conflict set |
   | C | Single-select `filterState.value` (`"status"` string) was coerced to `[]` instead of `["status"]` | Added string-to-array normalization branch |
   | 0 | Legacy display controls lack a `scope` field; `calculateScopes` returned `chartsInScope: []` and overwrote correctly-initialised `nativeFilters` state | Migrate legacy items via `migrateChartCustomizationArray` before `calculateScopes` |
   
   **Before** (broken request shape for Bug A):
   ```json
   {
     "groupby": ["status"],
     "filters": [{ "col": "status", "op": "IN", "val": ["status"] }]
   }
   ```
   
   **After** (correct):
   ```json
   {
     "groupby": ["status"]
   }
   ```
   
   The selected column is now treated only as a dimension, not incorrectly as a filter value.
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   
   Screenshots are not included in the PR body (local evidence files; no public hosting available at PR-open time). Reproduction network captures and V8 runtime proof are available in the branch at `.agor/workflows/display-control-does-not-affect-charts-dashboard/evidence/`.
   
   Key evidence files for reviewers:
   - `evidence/repro-r5-network.txt` — API request showing the broken `WHERE status IN ('status')` filter before the fix
   - `evidence/verify-r13-runtime-proof.png` — Browser V8 patched-function execution showing all three assertions PASS after the fix
   
   ### TESTING INSTRUCTIONS
   
   1. Create or open a dashboard with a chart that has a `groupby` field.
   2. Add a **Dynamic Group By** display control scoped to that chart.
   3. Select a column (e.g. `status`) and click _Apply Filters_.
   4. **Expected**: the chart re-queries with `groupby: ["status"]` — no spurious `filters` array.
   5. **Also verify**: selecting a column that was already in the chart's base `groupby` still applies (Bug B); selecting in single-select mode works (Bug C); legacy-format controls without a `scope` field work (Bug 0).
   
   **Automated tests** (20 passing):
   ```bash
   # Unit tests — getFormDataWithExtraFilters (11 tests)
   npm run test -- src/dashboard/util/getFormDataWithExtraFilters.test.ts
   
   # Integration tests — DashboardContainer (9 tests)
   npm run test -- src/dashboard/components/DashboardBuilder/DashboardContainer.test.tsx
   ```
   
   ### ADDITIONAL INFORMATION
   
   - [ ] Has associated issue:
   - [ ] Required feature flags:
   - [x] Changes UI
   - [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
     - [ ] Migration is atomic, supports rollback & is backwards-compatible
     - [ ] Confirm DB migration upgrade and downgrade tested
     - [ ] Runtime estimates and downtime expectations provided
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   
   **Files changed:**
   
   | File | Change |
   |------|--------|
   | `superset-frontend/src/dashboard/util/charts/getFormDataWithExtraFilters.ts` | Bugs A, B, C — removed `allFilters` block, removed `existingGroupBy` conflict lines, added string normalization |
   | `superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.tsx` | Bug 0 — migrate legacy display controls before `calculateScopes` |
   | `superset-frontend/src/dashboard/util/getFormDataWithExtraFilters.test.ts` | 11 unit regression tests |
   | `superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.test.tsx` | 9 integration tests + pre-existing `SupersetClient` mock crash fix |
   
   **Note on TypeScript pre-commit check**: The `type-checking-frontend` hook fails in this worktree due to unbuilt `@superset-ui/core` package declarations (TS6305) in files unrelated to this change. Zero TS errors exist in the four changed files. CI is the authoritative type check.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): display control (dynamic group-by) now affects charts [superset]

Posted by "Copilot (via GitHub)" <gi...@apache.org>.
Copilot commented on code in PR #39354:
URL: https://github.com/apache/superset/pull/39354#discussion_r3081678419


##########
superset-frontend/src/dashboard/util/charts/getFormDataWithExtraFilters.ts:
##########
@@ -135,9 +135,6 @@ function buildExistingColumnsSet(chart: ChartQueryPayload): Set<string> {
   const existingColumns = new Set<string>();
   const chartType = chart.form_data?.viz_type;
 
-  const existingGroupBy = ensureIsArray(chart.form_data?.groupby);
-  existingGroupBy.forEach((col: string) => existingColumns.add(col));
-
   const xAxisColumn = chart.form_data?.x_axis;
   if (xAxisColumn && chartType !== 'heatmap' && chartType !== 'heatmap_v2') {
     existingColumns.add(xAxisColumn);

Review Comment:
   Removing `groupby` from `buildExistingColumnsSet` fixes the no-op behavior (Bug B), but it also makes it possible for a user to select a column that already exists in `existingGroupBy`. For chart types that *append* to `existingGroupBy` (notably the `'chord'` branch in `applyChartSpecificGroupBy`), this can now introduce duplicate columns (e.g., `['status', 'status']`), which may cause invalid/inefficient queries or inconsistent UI behavior. Consider deduping the resulting `groupby` in the append case (or generally before returning group-by form data) to keep output stable.



##########
superset-frontend/src/dashboard/components/DashboardBuilder/DashboardContainer.test.tsx:
##########
@@ -438,3 +452,166 @@ test('calculates tabsInScope for filters with tab-scoped charts', async () => {
     ]),
   );
 });
+
+// ── Chart Customization scope tests ────────────────────────────────────────────
+//
+// These cover the useEffect in DashboardContainer that calls
+// setInScopeStatusOfCustomizations. The native-filter tests above only exercise
+// the setInScopeStatusOfFilters path; the customization path has no existing
+// coverage. The Bug 0 fix (migrateChartCustomizationArray before calculateScopes)
+// is specifically exercised in the legacy-format test.
+
+test('calculates chartsInScope correctly for new-format chart customizations', async () => {
+  const customizationId = 'CHART_CUSTOMIZATION-1';
+  const originalFn = chartCustomizationActions.setInScopeStatusOfCustomizations;
+  const spy = jest.spyOn(
+    chartCustomizationActions,
+    'setInScopeStatusOfCustomizations',
+  );
+  spy.mockImplementation(args => originalFn(args));
+
+  try {
+    const state = {
+      dashboardInfo: {
+        ...mockState.dashboardInfo,
+        metadata: {
+          ...mockState.dashboardInfo.metadata,
+          native_filter_configuration: [],
+          chart_customization_config: [
+            {
+              id: customizationId,
+              type: 'CHART_CUSTOMIZATION',
+              name: 'Dynamic Group By',
+              filterType: 'chart_customization_dynamic_groupby',
+              targets: [{ datasetId: 1, column: { name: 'status' } }],
+              scope: { rootPath: ['ROOT_ID'], excluded: [] },
+              chartsInScope: [],
+              defaultDataMask: {},
+              controlValues: {},
+            },
+          ],
+        },
+      },
+      nativeFilters: {
+        filters: {
+          [customizationId]: {
+            id: customizationId,
+            type: 'CHART_CUSTOMIZATION',
+            chartsInScope: [],
+          },
+        },
+      },
+    };
+    setup(state);
+
+    await waitFor(() => {
+      expect(spy).toHaveBeenCalledWith(
+        expect.arrayContaining([
+          expect.objectContaining({
+            customizationId,
+            chartsInScope: [sliceId],
+          }),
+        ]),
+      );
+    });
+  } finally {
+    spy.mockRestore();
+  }
+});
+
+test('migrates legacy-format customizations before scope calculation (Bug 0 integration)', async () => {
+  // Legacy items (stored with a `customization` wrapper, no `type` field) have no
+  // `scope` field. Without the migrateChartCustomizationArray call in DashboardContainer,
+  // calculateScopes would return chartsInScope:[] for these items (the Bug 0 regression).
+  // With the fix, migration adds scope:{rootPath:['ROOT_ID'], excluded:[]}, so the chart
+  // is correctly included in scope.
+  const legacyCustomizationId = 'CHART_CUSTOMIZATION-legacy-1';
+  const originalFn = chartCustomizationActions.setInScopeStatusOfCustomizations;
+  const spy = jest.spyOn(
+    chartCustomizationActions,
+    'setInScopeStatusOfCustomizations',
+  );
+  spy.mockImplementation(args => originalFn(args));
+
+  try {
+    const state = {
+      dashboardInfo: {
+        ...mockState.dashboardInfo,
+        metadata: {
+          ...mockState.dashboardInfo.metadata,
+          native_filter_configuration: [],
+          chart_customization_config: [
+            {
+              // Legacy format: has `customization` wrapper, NO `type` field.
+              // isLegacyChartCustomizationFormat returns true for this shape.
+              id: legacyCustomizationId,
+              customization: {
+                dataset: 1,
+                column: 'status',
+                filterType: 'chart_customization_dynamic_groupby',
+                name: 'Legacy Group By',
+              },
+              // No `scope` field — calculateScopes would return chartsInScope:[]
+              // without the migration fix.
+            },
+          ],
+        },
+      },
+      nativeFilters: {
+        filters: {
+          [legacyCustomizationId]: {
+            id: legacyCustomizationId,
+            chartsInScope: [],
+          },
+        },
+      },
+    };
+    setup(state);
+
+    await waitFor(() => {
+      expect(spy).toHaveBeenCalledWith(
+        expect.arrayContaining([
+          expect.objectContaining({
+            customizationId: legacyCustomizationId,
+            // Non-empty: migration produced scope:{rootPath:['ROOT_ID'], excluded:[]},
+            // so calculateScopes includes the chart rather than returning [].
+            chartsInScope: [sliceId],
+          }),
+        ]),
+      );
+    });
+  } finally {
+    spy.mockRestore();
+  }
+});
+
+test('does not dispatch setInScopeStatusOfCustomizations when chart_customization_config is empty', async () => {
+  const spy = jest.spyOn(
+    chartCustomizationActions,
+    'setInScopeStatusOfCustomizations',
+  );
+
+  try {
+    const state = {
+      dashboardInfo: {
+        ...mockState.dashboardInfo,
+        metadata: {
+          ...mockState.dashboardInfo.metadata,
+          native_filter_configuration: [],
+          chart_customization_config: [],
+        },
+      },
+      nativeFilters: { filters: {} },
+    };
+    setup(state);
+
+    // Allow any pending effects to settle
+    await new Promise(resolve => {
+      setTimeout(resolve, 50);
+    });
+
+    expect(spy).not.toHaveBeenCalled();

Review Comment:
   This `setTimeout(..., 50)`-based settling can be flaky under load (CI variance) and may still miss later-dispatched effects. Prefer using the testing utilities to deterministically flush effects (e.g., `waitFor` asserting the spy remains uncalled for the duration, or Jest fake timers with an explicit drain of timers/microtasks) so the test outcome does not depend on timing.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): display control (dynamic group-by) now affects charts [superset]

Posted by "richardfogaca (via GitHub)" <gi...@apache.org>.
richardfogaca closed pull request #39354: fix(dashboard): display control (dynamic group-by) now affects charts
URL: https://github.com/apache/superset/pull/39354


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): display control (dynamic group-by) now affects charts [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on code in PR #39354:
URL: https://github.com/apache/superset/pull/39354#discussion_r3082483475


##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/GroupByFilterCard.test.tsx:
##########
@@ -0,0 +1,182 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import { ChartCustomizationType } from '@superset-ui/core';
+import { render, screen, userEvent, waitFor, within } from 'spec/helpers/testing-library';
+import { useDispatch, useSelector } from 'react-redux';
+import { cachedSupersetGet } from 'src/utils/cachedSupersetGet';
+import GroupByFilterCard from './GroupByFilterCard';
+
+jest.mock('react-redux', () => ({
+  ...jest.requireActual('react-redux'),
+  useDispatch: jest.fn(),
+  useSelector: jest.fn(),
+}));
+
+jest.mock('src/utils/cachedSupersetGet', () => ({
+  cachedSupersetGet: jest.fn(),
+}));
+
+const dispatchMock = jest.fn();
+const mockUseDispatch = useDispatch as jest.Mock;
+const mockUseSelector = useSelector as jest.Mock;
+const mockCachedSupersetGet = cachedSupersetGet as jest.Mock;
+let selectorState: ReturnType<typeof makeSelectorState>;
+
+const customizationItem = {
+  id: 'CHART_CUSTOMIZATION-multi-select',
+  type: ChartCustomizationType.ChartCustomization,
+  name: 'Dynamic Group By',
+  filterType: 'dynamic_group_by',
+  targets: [{ datasetId: 3, column: { name: 'status' } }],
+  scope: {
+    rootPath: ['ROOT_ID'],
+    excluded: [],
+  },
+  chartsInScope: [42],
+  cascadeParentIds: [],
+  defaultDataMask: {
+    extraFormData: {},
+    filterState: {},
+  },
+  controlValues: {
+    canSelectMultiple: true,
+  },
+  description: 'Select one or more columns',
+};
+
+const makeSelectorState = (dataMaskSelected = {}) => ({
+  dataMask: dataMaskSelected,
+  nativeFilters: {
+    filters: {},
+  },
+});
+
+describe('GroupByFilterCard multi-select behavior', () => {
+  beforeEach(() => {
+    jest.clearAllMocks();
+    mockUseDispatch.mockReturnValue(dispatchMock);
+    selectorState = makeSelectorState();
+    mockUseSelector.mockImplementation(selector => selector(selectorState));
+    mockCachedSupersetGet.mockResolvedValue({
+      json: {
+        result: {
+          table_name: 'orders',
+          columns: [
+            { column_name: 'status', verbose_name: 'status' },
+            { column_name: 'region', verbose_name: 'region' },
+            { column_name: 'order_date', verbose_name: 'order_date' },
+          ],
+        },
+      },
+    });
+  });
+
+  test('multi-select group by persists selected values and stores a canonical target column name', async () => {
+    const onFilterSelectionChange = jest.fn();
+
+    const { rerender } = render(
+      <GroupByFilterCard
+        customizationItem={customizationItem as any}

Review Comment:
   <div>
   
   
   <div id="suggestion">
   <div id="issue"><b>Type Safety Violation</b></div>
   <div id="fix">
   
   The 'as any' type assertions on lines 96 and 152 bypass TypeScript's type checking, which violates project standards against using 'any' types. This reduces maintainability and can mask type errors. Use proper typing instead, as the component expects a ChartCustomization type.
   </div>
   
   
   <details>
   <summary>
   <b>Code suggestion</b>
   </summary>
   <blockquote>Check the AI-generated fix before applying</blockquote>
   <div id="code">
   
   
   ```
    - import { ChartCustomizationType } from '@superset-ui/core';
    + import { ChartCustomizationType, ChartCustomization } from '@superset-ui/core';
    @@ -42,1 +42,1 @@
    - const customizationItem = {
    + const customizationItem: ChartCustomization = {
    @@ -96,1 +96,1 @@
    -         customizationItem={customizationItem as any}
    +         customizationItem={customizationItem}
    @@ -152,1 +152,1 @@
    -         customizationItem={customizationItem as any}
    +         customizationItem={customizationItem}
   ```
   
   </div>
   </details>
   
   
   
   </div>
   
   <details>
   <summary><b>Citations</b></summary>
   <ul>
   
   <li>
   Rule Violated: <a href="https://github.com/apache/superset/blob/1cd17ea/.cursor/rules/dev-standard.mdc#L16">dev-standard.mdc:16</a>
   </li>
   
   <li>
   Rule Violated: <a href="https://github.com/apache/superset/blob/1cd17ea/AGENTS.md#L78">AGENTS.md:78</a>
   </li>
   
   </ul>
   </details>
   
   
   
   
   <small><i>Code Review Run #1c56f2</i></small>
   </div>
   
   ---
   Should Bito avoid suggestions like this for future reviews? (<a href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
   - [ ] Yes, avoid them



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): display control (dynamic group-by) now affects charts [superset]

Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #39354:
URL: https://github.com/apache/superset/pull/39354#issuecomment-4246735188

   ## [Codecov](https://app.codecov.io/gh/apache/superset/pull/39354?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `77.77778%` with `2 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 64.50%. Comparing base ([`de40b58`](https://app.codecov.io/gh/apache/superset/commit/de40b58e1050c823167a8d98da5a49603bf4cfa1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`01d28c7`](https://app.codecov.io/gh/apache/superset/commit/01d28c7432bc44165e1c8ed16471318dcc0dad3c?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   :warning: Report is 15 commits behind head on master.
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/superset/pull/39354?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [...shboard/util/charts/getFormDataWithExtraFilters.ts](https://app.codecov.io/gh/apache/superset/pull/39354?src=pr&el=tree&filepath=superset-frontend%2Fsrc%2Fdashboard%2Futil%2Fcharts%2FgetFormDataWithExtraFilters.ts&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2NoYXJ0cy9nZXRGb3JtRGF0YVdpdGhFeHRyYUZpbHRlcnMudHM=) | 60.00% | [2 Missing :warning: ](https://app.codecov.io/gh/apache/superset/pull/39354?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   :x: Your project check has failed because the head coverage (99.81%) is below the target coverage (100.00%). You can increase the head coverage or adjust the [target](https://docs.codecov.com/docs/commit-status#target) coverage.
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #39354      +/-   ##
   ==========================================
   + Coverage   64.42%   64.50%   +0.08%     
   ==========================================
     Files        2553     2553              
     Lines      132588   132587       -1     
     Branches    30758    30761       +3     
   ==========================================
   + Hits        85416    85531     +115     
   + Misses      45686    45570     -116     
     Partials     1486     1486              
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/superset/pull/39354/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [javascript](https://app.codecov.io/gh/apache/superset/pull/39354/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `66.27% <77.77%> (+0.15%)` | :arrow_up: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/39354?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): display control (dynamic group-by) now affects charts [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39354:
URL: https://github.com/apache/superset/pull/39354#issuecomment-4247031209

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): display control (dynamic group-by) now affects charts [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39354:
URL: https://github.com/apache/superset/pull/39354#issuecomment-4246285071

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


Re: [PR] fix(dashboard): display control (dynamic group-by) now affects charts [superset]

Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #39354:
URL: https://github.com/apache/superset/pull/39354#issuecomment-4247445982

   AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
   
   <details>
   <summary>
   Bito Usage Guide
   </summary>
   
   **Commands**
         
   Type the following command in the pull request comment and save the comment.
         
   - `/review` - Manually triggers a full AI review.
   
   - `/pause` - Pauses automatic reviews on this pull request.
   - `/resume` - Resumes automatic reviews.
   - `/resolve` - Marks all Bito-posted review comments as resolved.
   - `/abort` - Cancels all in-progress reviews.
   
         
   Refer to the <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/available-commands" target="_blank" rel="noopener noreferrer">documentation</a> for additional commands.
         
   **Configuration**
   
   This repository uses `Superset` You can customize the agent settings <a href="https://alpha.bito.ai/home/ai-agents/code-review-agent" target="_blank" rel="noopener noreferrer">here</a> or contact your Bito workspace admin at evan@preset.io.
         
   **Documentation & Help**
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/getting-started/install-run-using-bito-cloud/create-or-customize-an-agent-instance" target="_blank" rel="noopener noreferrer">Customize agent settings</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/implementing-custom-code-review-rules" target="_blank" rel="noopener noreferrer">Review rules</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent" target="_blank" rel="noopener noreferrer">General documentation</a>
   - <a href="https://docs.bito.ai/bito-dev-agents/ai-code-review-agent/faqs" target="_blank" rel="noopener noreferrer">FAQ</a>
   
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org