You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/09/13 07:04:58 UTC
[GitHub] [cloudstack] Pearl1594 opened a new pull request #5439: ui: Fix Scale VM failure - missing args when customized compute offering is used
Pearl1594 opened a new pull request #5439:
URL: https://github.com/apache/cloudstack/pull/5439
### Description
This PR fixes the failure noticed during scale VM operation when a custom offering is selected. It observed that when cpuNumber / cpu speed is provided for the selected custom compute offering, it fails to pass the args properly
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [X] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
Successfully scaled VM - args properly passed:
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5439: ui: Fix Scale VM failure - missing args when custom compute offering is selected
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5439:
URL: https://github.com/apache/cloudstack/pull/5439#issuecomment-918021326
Yes @shwstppr, but since it isn't a critical issue, I've targeted the fix for 4.16
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5439: ui: Fix Scale VM failure - missing args when custom compute offering is selected
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5439:
URL: https://github.com/apache/cloudstack/pull/5439#issuecomment-917909115
UI build: :heavy_check_mark:
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5439 (SL-JID-644)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5439: ui: Fix Scale VM failure - missing args when custom compute offering is selected
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5439:
URL: https://github.com/apache/cloudstack/pull/5439#issuecomment-918158798
@rhtyd It's not a blocker - one can use the legacy UI / cmk to achieve the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] nvazquez merged pull request #5439: ui: Fix Scale VM failure - missing args when custom compute offering is selected
Posted by GitBox <gi...@apache.org>.
nvazquez merged pull request #5439:
URL: https://github.com/apache/cloudstack/pull/5439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5439: ui: Fix Scale VM failure - missing args when custom compute offering is selected
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5439:
URL: https://github.com/apache/cloudstack/pull/5439#issuecomment-918154578
@Pearl1594 is this a critical/blocker issue for 4.15; for example is there a workaround possible with using API or legacy UI?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] Pearl1594 commented on pull request #5439: ui: Fix Scale VM failure - missing args when custom compute offering is selected
Posted by GitBox <gi...@apache.org>.
Pearl1594 commented on pull request #5439:
URL: https://github.com/apache/cloudstack/pull/5439#issuecomment-917903512
@blueorangutan ui
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5439: ui: Fix Scale VM failure - missing args when custom compute offering is selected
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5439:
URL: https://github.com/apache/cloudstack/pull/5439#issuecomment-917904472
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] rhtyd commented on pull request #5439: ui: Fix Scale VM failure - missing args when custom compute offering is selected
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #5439:
URL: https://github.com/apache/cloudstack/pull/5439#issuecomment-917986639
LGTM but @shwstppr to confirm
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org