You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/03/08 19:10:00 UTC

[GitHub] sijie commented on a change in pull request #1236: Issue #570: make changes to SyncThread/checkpoint logic.

sijie commented on a change in pull request #1236: Issue #570: make changes to SyncThread/checkpoint logic.
URL: https://github.com/apache/bookkeeper/pull/1236#discussion_r173259411
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SyncThread.java
 ##########
 @@ -119,6 +119,12 @@ public void startCheckpoint(Checkpoint checkpoint) {
         });
     }
 
+    void start() {
 
 Review comment:
   Can you rename this to "scheduleCheckpointAtFixedRate(long flushIntervalMs)" as I suggested in #1201?
   
   - it is not actually a "start" action because the scheduler has been started, this is more a "schedule" action
   - flushInterval doesn't belong to SyncThread any more.
   
   Also can you update the comment about 'flushInterval' in ServerConfiguration and conf/bk_server.conf, `site/_data/config/bk_server.yaml`? `flushInterval` is now only works when `entryLogPerLedger` enabled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services