[GitHub] [gobblin] aplex commented on a change in pull request #3311: [GOBBLIN-1472] toggle to control compaction MR output dir

[GitBox <gi...@apache.org>]

aplex commented on a change in pull request #3311:
URL: https://github.com/apache/gobblin/pull/3311#discussion_r651362512



##########
File path: gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/CompactionJobConfigurator.java
##########
@@ -249,6 +250,10 @@ protected boolean configureInputAndOutputPaths(Job job, FileSystemDataset datase
     CompactionPathParser.CompactionParserResult rst = parser.parse(dataset);
     this.mrOutputPath = concatPaths(mrOutputBase, rst.getDatasetName(), rst.getDstSubDir(), rst.getTimeString());
 
+    if(this.state.contains(ConfigurationKeys.USE_DATASET_LOCAL_WORK_DIR)) {
+      mrOutputBase = this.state.getProp(MRCompactor.COMPACTION_DEST_DIR);
+      this.mrOutputPath = concatPaths(mrOutputBase, rst.getDatasetName(), ConfigurationKeys.TMP_DIR, rst.getDstSubDir(), rst.getTimeString());

Review comment:
       CI process should check the code style, looks like it's not working as expected. Worth checking why it's not raising an error.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org