You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/12/17 12:49:51 UTC
[GitHub] [dolphinscheduler-sdk-python] zhongjiajie opened a new pull request, #54: [impv] Remove tenant define is workflow
zhongjiajie opened a new pull request, #54:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/54
<!--Thanks for you contribute to Apache DolphinScheduler Python API, You can see more detail about contributing in https://github.com/apache/dolphinscheduler-sdk-python/DEVELOP.md .-->
## Brief Summary of The Change
<!--Please include `fixes: #XXXX(ISSUE_NUMBER)` to automatically close any corresponding issue when the pull request is merged. Alternatively if not fully closed you can say `related: #XXXX(ISSUE_NUMBER)`.-->
current tenant in workflow only work when the first time user do not exist, when user change the tenant in workflow but tenant exist, it will be ignore, so we try to remove it from workflow, and in #40 we try to create both user and tenant vis cli instead of auto create
## Pull Request checklist
I confirm that the following checklist has been completed.
- [x] Add/Change **test cases** for the changes.
- [x] Add/Change the related **documentation**, should also change `docs/source/config.rst` when you change file `default_config.yaml`.
- [x] (Optional) Add your change to `UPDATING.md` when it is an incompatible change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-sdk-python] codecov-commenter commented on pull request #54: [impv] Remove tenant define is workflow
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #54:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/54#issuecomment-1356268270
# [Codecov](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/54?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#54](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/54?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (169d955) into [main](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/commit/229aa8b61b4a7d712c79e6d4ee1aef332062d08d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (229aa8b) will **decrease** coverage by `0.22%`.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## main #54 +/- ##
==========================================
- Coverage 90.80% 90.58% -0.23%
==========================================
Files 60 60
Lines 2110 2103 -7
==========================================
- Hits 1916 1905 -11
- Misses 194 198 +4
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `90.58% <100.00%> (-0.23%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/54?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [src/pydolphinscheduler/models/tenant.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9tb2RlbHMvdGVuYW50LnB5) | `40.00% <ø> (-16.67%)` | :arrow_down: |
| [src/pydolphinscheduler/models/user.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9tb2RlbHMvdXNlci5weQ==) | `50.00% <ø> (ø)` | |
| [src/pydolphinscheduler/configuration.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9jb25maWd1cmF0aW9uLnB5) | `97.01% <100.00%> (ø)` | |
| [src/pydolphinscheduler/core/workflow.py](https://codecov.io/gh/apache/dolphinscheduler-sdk-python/pull/54/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3JjL3B5ZG9scGhpbnNjaGVkdWxlci9jb3JlL3dvcmtmbG93LnB5) | `81.71% <100.00%> (-0.16%)` | :arrow_down: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-sdk-python] zhongjiajie commented on pull request #54: [impv] Remove tenant define is workflow
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #54:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/54#issuecomment-1356268035
ref: https://github.com/apache/dolphinscheduler/pull/13212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-sdk-python] zhongjiajie merged pull request #54: [impv] Remove tenant define is workflow
Posted by GitBox <gi...@apache.org>.
zhongjiajie merged PR #54:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/54
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler-sdk-python] zhongjiajie commented on pull request #54: [impv] Remove tenant define is workflow
Posted by "zhongjiajie (via GitHub)" <gi...@apache.org>.
zhongjiajie commented on PR #54:
URL: https://github.com/apache/dolphinscheduler-sdk-python/pull/54#issuecomment-1481060542
> ref: [apache/dolphinscheduler#13212](https://github.com/apache/dolphinscheduler/pull/13212)
may release in version apache/dolphinscheduler:3.1.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org