You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Alex Behm (Code Review)" <ge...@cloudera.org> on 2017/03/21 05:15:28 UTC
[Impala-ASF-CR] Pass build type to Impala LZO.
Alex Behm has uploaded a new change for review.
http://gerrit.cloudera.org:8080/6446
Change subject: Pass build type to Impala LZO.
......................................................................
Pass build type to Impala LZO.
Before, the build type used for Impala LZO was always debug.
Now, the build type is passed from the Impala CMakeLists.txt.
This patch needs corresponding changes to Impala LZO.
Testing: I tested locally with these build types:
DEBUG, RELEASE, and ADDRESS_SANITIZER.
Change-Id: Ia83e594409ad5938662ca210c810d5d31b8637b0
---
M CMakeLists.txt
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/46/6446/1
--
To view, visit http://gerrit.cloudera.org:8080/6446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia83e594409ad5938662ca210c810d5d31b8637b0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
[Impala-ASF-CR] Pass build type to Impala LZO.
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: Pass build type to Impala LZO.
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/6446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia83e594409ad5938662ca210c810d5d31b8637b0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Pass build type to Impala LZO.
Posted by "Jim Apple (Code Review)" <ge...@cloudera.org>.
Jim Apple has posted comments on this change.
Change subject: Pass build type to Impala LZO.
......................................................................
Patch Set 1:
Fixes https://issues.apache.org/jira/browse/IMPALA-4699?
--
To view, visit http://gerrit.cloudera.org:8080/6446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia83e594409ad5938662ca210c810d5d31b8637b0
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Pass build type to Impala LZO.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: Pass build type to Impala LZO.
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/6446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia83e594409ad5938662ca210c810d5d31b8637b0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Pass build type to Impala LZO.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has posted comments on this change.
Change subject: Pass build type to Impala LZO.
......................................................................
Patch Set 2: Code-Review+2
Merging this change directly after manual validation. It needs a coordinated change with Impala-Lzo. GVO and private testing of such coordinated changes is currently not supported on jenkins.impala.io. I filed https://issues.apache.org/jira/browse/IMPALA-5148 to improve this.
Jim, I could not find an easy way for me to test whether this fixes IMPALA-4699 as well. I don't think my change has anything to do with that JIRA.
--
To view, visit http://gerrit.cloudera.org:8080/6446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia83e594409ad5938662ca210c810d5d31b8637b0
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Impala-ASF-CR] Pass build type to Impala LZO.
Posted by "Alex Behm (Code Review)" <ge...@cloudera.org>.
Alex Behm has submitted this change and it was merged.
Change subject: Pass build type to Impala LZO.
......................................................................
Pass build type to Impala LZO.
Before, the build type used for Impala LZO was always debug.
Now, the build type is passed from the Impala CMakeLists.txt.
This patch needs corresponding changes to Impala LZO.
Testing: I tested locally with these build types:
DEBUG, RELEASE, and ADDRESS_SANITIZER.
Change-Id: Ia83e594409ad5938662ca210c810d5d31b8637b0
Reviewed-on: http://gerrit.cloudera.org:8080/6446
Reviewed-by: Alex Behm <al...@cloudera.com>
Tested-by: Alex Behm <al...@cloudera.com>
---
M CMakeLists.txt
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alex Behm: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/6446
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia83e594409ad5938662ca210c810d5d31b8637b0
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Alex Behm <al...@cloudera.com>
Gerrit-Reviewer: Jim Apple <jb...@apache.org>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>