You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/11/18 13:18:18 UTC
[GitHub] [dubbo-go-hessian2] Leospard opened a new pull request, #338: Export getArgType
Leospard opened a new pull request, #338:
URL: https://github.com/apache/dubbo-go-hessian2/pull/338
<!-- Thanks for sending a pull request!
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] tiltwind commented on pull request #338: Export getArgType
Posted by GitBox <gi...@apache.org>.
tiltwind commented on PR #338:
URL: https://github.com/apache/dubbo-go-hessian2/pull/338#issuecomment-1320826394
@Leospard u should not use dubbo protocol in this library, use [that](https://github.com/apache/dubbo-go/blob/d70b6c0db44b4790ff4de1be8936162817be8080/protocol/dubbo/hessian2/hessian_request.go#L35) in dubbo-go instead. The dubbo protocol code has already bean moved to dubbo-go project. I think the relative code should be marked as deprecated. This project will focus on the implement of hessian2 serilization
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] wongoo commented on pull request #338: Export getArgType
Posted by GitBox <gi...@apache.org>.
wongoo commented on PR #338:
URL: https://github.com/apache/dubbo-go-hessian2/pull/338#issuecomment-1320727394
@Leospard why it's need to export getArgType? What will u use it for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] Leospard commented on pull request #338: Export getArgType
Posted by GitBox <gi...@apache.org>.
Leospard commented on PR #338:
URL: https://github.com/apache/dubbo-go-hessian2/pull/338#issuecomment-1320807163
> @Leospard why it's need to export getArgType? What will u use it for?
It will be used in triple. Previously encoding/java_type.go just copy all the code of this method, and I wanna to wrap an exported method to avoid maybe some unexpected problems in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] tiltwind commented on pull request #338: Export getArgType
Posted by GitBox <gi...@apache.org>.
tiltwind commented on PR #338:
URL: https://github.com/apache/dubbo-go-hessian2/pull/338#issuecomment-1320837338
see https://github.com/apache/dubbo-go-hessian2/pull/339/files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on a diff in pull request #338: Export getArgType
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on code in PR #338:
URL: https://github.com/apache/dubbo-go-hessian2/pull/338#discussion_r1027043482
##########
request.go:
##########
@@ -33,6 +33,10 @@ import (
// dubbo
/////////////////////////////////////////
+func GetArgType(v interface{}) string {
Review Comment:
个人觉得应该是这样。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] Leospard closed pull request #338: Export getArgType
Posted by GitBox <gi...@apache.org>.
Leospard closed pull request #338: Export getArgType
URL: https://github.com/apache/dubbo-go-hessian2/pull/338
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] Leospard commented on a diff in pull request #338: Export getArgType
Posted by GitBox <gi...@apache.org>.
Leospard commented on code in PR #338:
URL: https://github.com/apache/dubbo-go-hessian2/pull/338#discussion_r1027044441
##########
request.go:
##########
@@ -33,6 +33,10 @@ import (
// dubbo
/////////////////////////////////////////
+func GetArgType(v interface{}) string {
Review Comment:
👌 fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] AlexStocks commented on a diff in pull request #338: Export getArgType
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on code in PR #338:
URL: https://github.com/apache/dubbo-go-hessian2/pull/338#discussion_r1026827559
##########
request.go:
##########
@@ -33,6 +33,10 @@ import (
// dubbo
/////////////////////////////////////////
+func GetArgType(v interface{}) string {
Review Comment:
直接把下面函数改下不就行了？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] Leospard commented on a diff in pull request #338: Export getArgType
Posted by GitBox <gi...@apache.org>.
Leospard commented on code in PR #338:
URL: https://github.com/apache/dubbo-go-hessian2/pull/338#discussion_r1027036094
##########
request.go:
##########
@@ -33,6 +33,10 @@ import (
// dubbo
/////////////////////////////////////////
+func GetArgType(v interface{}) string {
Review Comment:
当时直观想着就是包装一下 Export 出来给 triple encoding 使用就行，不用修改其他的了。也可以直接改下面的，直接修改更好是嘛，我自己不是很确定
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go-hessian2] codecov-commenter commented on pull request #338: Export getArgType
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #338:
URL: https://github.com/apache/dubbo-go-hessian2/pull/338#issuecomment-1320820949
# [Codecov](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/338?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#338](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/338?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (417d47f) into [master](https://codecov.io/gh/apache/dubbo-go-hessian2/commit/e579ddaae68d4a418a32cd09b225413ce59d2911?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e579dda) will **not change** coverage.
> The diff coverage is `100.00%`.
```diff
@@ Coverage Diff @@
## master #338 +/- ##
=======================================
Coverage 72.17% 72.17%
=======================================
Files 27 27
Lines 3127 3127
=======================================
Hits 2257 2257
Misses 633 633
Partials 237 237
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/338?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [request.go](https://codecov.io/gh/apache/dubbo-go-hessian2/pull/338/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVxdWVzdC5nbw==) | `61.50% <100.00%> (ø)` | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org