[GitHub] [spark] cloud-fan commented on a change in pull request #24085: [SPARK-26555][SQL] make ScalaReflection subtype checking thread safe

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #24085: [SPARK-26555][SQL] make ScalaReflection subtype checking thread safe
URL: https://github.com/apache/spark/pull/24085#discussion_r265825702
 
 

 ##########
 File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/ScalaReflection.scala
 ##########
 @@ -66,19 +66,25 @@ object ScalaReflection extends ScalaReflection {
    */
   def dataTypeFor[T : TypeTag]: DataType = dataTypeFor(localTypeOf[T])
 
+  private[catalyst] def isSubtype(tpe1: `Type`, tpe2: `Type`): Boolean = {
 
 Review comment:
   can we add some comments to explain it and link to the scala bug report?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org