[GitHub] [ignite-3] ibessonov commented on a diff in pull request #1839: IGNITE-19119 Prepare org.apache.ignite.internal.storage.index.IndexStorage to built index

["ibessonov (via GitHub)" <gi...@apache.org>]

ibessonov commented on code in PR #1839:
URL: https://github.com/apache/ignite-3/pull/1839#discussion_r1149322282


##########
modules/storage-api/src/main/java/org/apache/ignite/internal/storage/index/IndexStorage.java:
##########
@@ -49,9 +51,29 @@ public interface IndexStorage {
      * <p>Removing a non-existent row is a no-op.
      *
      * @apiNote This method <b>must</b> always be called inside the corresponding partition's
-     *     {@link org.apache.ignite.internal.storage.MvPartitionStorage#runConsistently} closure.
+     *     {@link MvPartitionStorage#runConsistently} closure.
      *
      * @throws StorageException If failed to remove data.
      */
     void remove(IndexRow row) throws StorageException;
+
+    /**
+     * Returns the row ID for which the index needs to be built, {@code null} means that the index building has completed.
+     *
+     * <p>If index building has not started yet, it will return {@link RowId#lowestRowId(int)}.
+     *
+     * @throws StorageException If failed to get the row ID.
+     */
+    @Nullable RowId getNextRowIdToBuild();

Review Comment:
   From my side - exception in the signature simply makes it more explicit.
   StorageException should have been checked, and we wouldn't have this discussion in such case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@ignite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org