You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Will Berkeley (Code Review)" <ge...@cloudera.org> on 2018/02/02 19:00:10 UTC
[kudu-CR] Fix log message when there's too few data dirs for a data dir group
Will Berkeley has uploaded this change for review. ( http://gerrit.cloudera.org:8080/9194
Change subject: Fix log message when there's too few data dirs for a data dir group
......................................................................
Fix log message when there's too few data dirs for a data dir group
The address of the dirs full and dirs failed metrics were being
logged instead of the metric value:
I0201 14:45:22.566895 3316 data_dirs.cc:930] Could only allocate 1 dirs of requested 3 for tablet 78a4a8db9829474e84b7a5474c9114fd. 1 dirs total, 0x379c750 dirs full, 0x37599b0 dirs failed
Change-Id: I877d335a75625a087e4e9027b7f311fc8c0805c9
---
M src/kudu/fs/data_dirs.cc
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/9194/1
--
To view, visit http://gerrit.cloudera.org:8080/9194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I877d335a75625a087e4e9027b7f311fc8c0805c9
Gerrit-Change-Number: 9194
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
[kudu-CR] Fix log message when there's too few data dirs for a data dir group
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9194 )
Change subject: Fix log message when there's too few data dirs for a data dir group
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9194/1/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:
http://gerrit.cloudera.org:8080/#/c/9194/1/src/kudu/fs/data_dirs.cc@928
PS1, Line 928: $1 dirs full, $2
$0 and $1
--
To view, visit http://gerrit.cloudera.org:8080/9194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I877d335a75625a087e4e9027b7f311fc8c0805c9
Gerrit-Change-Number: 9194
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 02 Feb 2018 21:35:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] Fix log message when there's too few data dirs for a data dir group
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/9194 )
Change subject: Fix log message when there's too few data dirs for a data dir group
......................................................................
Fix log message when there's too few data dirs for a data dir group
The address of the dirs full and dirs failed metrics were being
logged instead of the metric value:
I0201 14:45:22.566895 3316 data_dirs.cc:930] Could only allocate 1 dirs of requested 3 for tablet 78a4a8db9829474e84b7a5474c9114fd. 1 dirs total, 0x379c750 dirs full, 0x37599b0 dirs failed
Change-Id: I877d335a75625a087e4e9027b7f311fc8c0805c9
Reviewed-on: http://gerrit.cloudera.org:8080/9194
Tested-by: Kudu Jenkins
Reviewed-by: Andrew Wong <aw...@cloudera.com>
---
M src/kudu/fs/data_dirs.cc
1 file changed, 4 insertions(+), 3 deletions(-)
Approvals:
Kudu Jenkins: Verified
Andrew Wong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/9194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I877d335a75625a087e4e9027b7f311fc8c0805c9
Gerrit-Change-Number: 9194
Gerrit-PatchSet: 3
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
[kudu-CR] Fix log message when there's too few data dirs for a data dir group
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9194 )
Change subject: Fix log message when there's too few data dirs for a data dir group
......................................................................
Patch Set 1: Code-Review+2
Thanks for catching that!
--
To view, visit http://gerrit.cloudera.org:8080/9194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I877d335a75625a087e4e9027b7f311fc8c0805c9
Gerrit-Change-Number: 9194
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Fri, 02 Feb 2018 19:05:05 +0000
Gerrit-HasComments: No
[kudu-CR] Fix log message when there's too few data dirs for a data dir group
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/9194 )
Change subject: Fix log message when there's too few data dirs for a data dir group
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/9194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I877d335a75625a087e4e9027b7f311fc8c0805c9
Gerrit-Change-Number: 9194
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 02 Feb 2018 22:33:30 +0000
Gerrit-HasComments: No
[kudu-CR] Fix log message when there's too few data dirs for a data dir group
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/9194
to look at the new patch set (#2).
Change subject: Fix log message when there's too few data dirs for a data dir group
......................................................................
Fix log message when there's too few data dirs for a data dir group
The address of the dirs full and dirs failed metrics were being
logged instead of the metric value:
I0201 14:45:22.566895 3316 data_dirs.cc:930] Could only allocate 1 dirs of requested 3 for tablet 78a4a8db9829474e84b7a5474c9114fd. 1 dirs total, 0x379c750 dirs full, 0x37599b0 dirs failed
Change-Id: I877d335a75625a087e4e9027b7f311fc8c0805c9
---
M src/kudu/fs/data_dirs.cc
1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/94/9194/2
--
To view, visit http://gerrit.cloudera.org:8080/9194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I877d335a75625a087e4e9027b7f311fc8c0805c9
Gerrit-Change-Number: 9194
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] Fix log message when there's too few data dirs for a data dir group
Posted by "Will Berkeley (Code Review)" <ge...@cloudera.org>.
Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/9194 )
Change subject: Fix log message when there's too few data dirs for a data dir group
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/9194/1/src/kudu/fs/data_dirs.cc
File src/kudu/fs/data_dirs.cc:
http://gerrit.cloudera.org:8080/#/c/9194/1/src/kudu/fs/data_dirs.cc@928
PS1, Line 928: $1 dirs full, $2
> $0 and $1
Done
--
To view, visit http://gerrit.cloudera.org:8080/9194
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I877d335a75625a087e4e9027b7f311fc8c0805c9
Gerrit-Change-Number: 9194
Gerrit-PatchSet: 1
Gerrit-Owner: Will Berkeley <wd...@gmail.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Will Berkeley <wd...@gmail.com>
Gerrit-Comment-Date: Fri, 02 Feb 2018 21:46:10 +0000
Gerrit-HasComments: Yes