You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/06/19 21:59:11 UTC
[GitHub] [superset] mvoitko opened a new pull request #15273: Update ingress api version to v1
mvoitko opened a new pull request #15273:
URL: https://github.com/apache/superset/pull/15273
### SUMMARY
Update ingress api version to v1
extensions/v1beta1 Ingress is deprecated in v1.14+, unavailable in v1.22+;
networking.k8s.io/v1 Ingress should be used
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
`helm upgrade --install --values ./values.yaml superset superset/superset --dry-run`
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Hokwang commented on pull request #15273: feat: update ingress api version to v1
Posted by GitBox <gi...@apache.org>.
Hokwang commented on pull request #15273:
URL: https://github.com/apache/superset/pull/15273#issuecomment-872117757
Now this PR looks good for me. But I am not a maintainer, reviewer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mvoitko commented on pull request #15273: feat: update ingress api version to v1
Posted by GitBox <gi...@apache.org>.
mvoitko commented on pull request #15273:
URL: https://github.com/apache/superset/pull/15273#issuecomment-872027070
@Hokwang modified according to your comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Hokwang commented on pull request #15273: Update ingress api version to v1
Posted by GitBox <gi...@apache.org>.
Hokwang commented on pull request #15273:
URL: https://github.com/apache/superset/pull/15273#issuecomment-864663453
you need to edit more. please refer to https://kubernetes.io/docs/concepts/services-networking/ingress/
```
...
pathType: Prefix
backend:
service:
name: test
port:
number: 80
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jqysn commented on pull request #15273: feat: update ingress api version to v1
Posted by GitBox <gi...@apache.org>.
jqysn commented on pull request #15273:
URL: https://github.com/apache/superset/pull/15273#issuecomment-884824567
When I install via helm, it returned "Error: UPGRADE FAILED: unable to recognize "": no matches for kind "Ingress" in version "networking.k8s.io/v1", is this related with this pr?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] craig-rueda commented on pull request #15273: feat: update ingress api version to v1
Posted by GitBox <gi...@apache.org>.
craig-rueda commented on pull request #15273:
URL: https://github.com/apache/superset/pull/15273#issuecomment-884988759
Likely is. What version of kubernetes are you running? 'v1' is available starting with 1.19.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 merged pull request #15273: feat: update ingress api version to v1
Posted by GitBox <gi...@apache.org>.
amitmiran137 merged pull request #15273:
URL: https://github.com/apache/superset/pull/15273
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mvoitko commented on pull request #15273: Update ingress api version to v1
Posted by GitBox <gi...@apache.org>.
mvoitko commented on pull request #15273:
URL: https://github.com/apache/superset/pull/15273#issuecomment-867210689
@Hokwang Could you please review?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] Hokwang commented on pull request #15273: feat: update ingress api version to v1
Posted by GitBox <gi...@apache.org>.
Hokwang commented on pull request #15273:
URL: https://github.com/apache/superset/pull/15273#issuecomment-871860772
I think that you need to provide a way for changing `pathType`. and default is `ImplementationSpecific`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org