[GitHub] [iceberg] yyanyy commented on a change in pull request #2543: Spark: Handle Instant and LocalDate in filter expressions (#2530)

[GitBox <gi...@apache.org>]

yyanyy commented on a change in pull request #2543:
URL: https://github.com/apache/iceberg/pull/2543#discussion_r623493930



##########
File path: spark3/src/main/java/org/apache/iceberg/spark/SparkFilters.java
##########
@@ -198,6 +200,10 @@ private static Object convertLiteral(Object value) {
       return DateTimeUtils.fromJavaTimestamp((Timestamp) value);
     } else if (value instanceof Date) {
       return DateTimeUtils.fromJavaDate((Date) value);
+    } else if (value instanceof Instant) {

Review comment:
       Do we know passed in `Instant` always correspond to type `timestamptz` but not `date`?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org