You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by samelamin <gi...@git.apache.org> on 2017/04/01 14:44:55 UTC

[GitHub] spark pull request #17487: [Spark-20145] [WIP] Fix range case insensitive bu...

Github user samelamin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17487#discussion_r109286453
  
    --- Diff: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala ---
    @@ -105,7 +105,7 @@ object ResolveTableValuedFunctions extends Rule[LogicalPlan] {
     
       override def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
         case u: UnresolvedTableValuedFunction if u.functionArgs.forall(_.resolved) =>
    -      builtinFunctions.get(u.functionName) match {
    +      builtinFunctions.get(u.functionName.toLowerCase) match {
    --- End diff --
    
    @hvanhovell instead of creating a new case class, is there a way I can reuse the UnresolvedTableValuedFunction case class and just add in the SQLConf class?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org