You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by ijokarumawak <gi...@git.apache.org> on 2016/08/24 09:08:15 UTC
[GitHub] nifi pull request #927: NIFI-2459: HTTP Site-to-Site can't update remote pee...
GitHub user ijokarumawak opened a pull request:
https://github.com/apache/nifi/pull/927
NIFI-2459: HTTP Site-to-Site can't update remote peer topology if the "bootstrap url" node is down
This PR migrates existing code which handles the situation, from EndpointConnectionPool to PeerSelector, so that both RAW and HTTP transport protocol has the same capability.
Added a unit test to confirm this scenario.
Also did an IT test using running NiFi cluster:
Used a 3 node cluster. Setup S2S specifying node 2 as the bootstrap node, then stop node 2. Confirm data is sent to only node 1 and 3. Remote peer status can still be refreshed. Then add Node 2 back, Confirm data is sent to node 1, 2 and 3.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ijokarumawak/nifi nifi-2459
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/927.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #927
----
commit ca3a365d4ec649f7d4b5742c37fb6c250bb73540
Author: Koji Kawamura <ij...@apache.org>
Date: 2016-08-24T08:59:25Z
NIFI-2459: Site-to-Site bootstrap node failure
Refresh remote peer statuses even if the bootstrap node goes down.
Migrate existing code which handles the situation from
EndpointConnectionPool to PeerSelector, so that both RAW and HTTP
transport protocol has the same capability.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #927: NIFI-2459: HTTP Site-to-Site can't update remote peer topol...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/927
@ijokarumawak excellent - thanks for getting this in! Code looks good. Will do some verification and then if all looks good will push to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi issue #927: NIFI-2459: HTTP Site-to-Site can't update remote peer topol...
Posted by markap14 <gi...@git.apache.org>.
Github user markap14 commented on the issue:
https://github.com/apache/nifi/pull/927
Looks good. Was able to verify the behavior and the results were exactly as expected! A big thanks for tackling this! +1 merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] nifi pull request #927: NIFI-2459: HTTP Site-to-Site can't update remote pee...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/927
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---