You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Maxim Khutornenko <ma...@apache.org> on 2014/09/08 23:46:29 UTC

Review Request 25455: Deprecating PopulateJobResult.populated thrift field.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25455/
-----------------------------------------------------------

Review request for Aurora, Bill Farner and Zameer Manji.


Repository: aurora


Description
-------

Deprecating PopulateJobResult.populated thrift field.


Diffs
-----

  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2 
  src/main/python/apache/aurora/client/api/updater.py 927b646f32300301f4e0d286465140795faf3d54 
  src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf 
  src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c 
  src/main/thrift/org/apache/aurora/gen/api.thrift c00f94371a27ffab41188b22f81bb1c8ec7a57e9 
  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 0d51f7dc367081f72090736e36605bf363f3395e 
  src/test/python/apache/aurora/client/api/test_updater.py 720885ef1864f325346b7060b9aad2083665a7b1 
  src/test/python/apache/aurora/client/cli/test_diff.py 38629b63c082cf81cb891dace2a70d9e8f418e18 
  src/test/python/apache/aurora/client/cli/test_restart.py 92aefe612dd59df75188fd7fc8cf080c9a878dde 
  src/test/python/apache/aurora/client/cli/test_update.py 8b7d11202b35deb09a0000248cfe0a96458fb70c 
  src/test/python/apache/aurora/client/commands/test_diff.py aa1e87fd60a8541a9f65f28f718f77d0e1cd5e3a 
  src/test/python/apache/aurora/client/commands/test_restart.py 0b71bbbdbb3058bd89e23d909efc6db1121d76b7 
  src/test/python/apache/aurora/client/commands/test_update.py 85b8423ab604d44406cb31000f63f8a45885296c 
  src/test/resources/org/apache/aurora/gen/api.thrift.md5 85de4b3e2915f7450ca9f88e2f3a875d9d821885 

Diff: https://reviews.apache.org/r/25455/diff/


Testing
-------

gradle -Pq build
./pants src/test/python:all


Thanks,

Maxim Khutornenko

Re: Review Request 25455: Deprecating PopulateJobResult.populated thrift field.

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25455/
-----------------------------------------------------------

(Updated Sept. 12, 2014, 6:35 p.m.)


Review request for Aurora, Bill Farner and Zameer Manji.


Changes
-------

rebased


Repository: aurora


Description
-------

Deprecating PopulateJobResult.populated thrift field.


Diffs (updated)
-----

  src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2 
  src/main/python/apache/aurora/client/api/updater.py 927b646f32300301f4e0d286465140795faf3d54 
  src/main/python/apache/aurora/client/cli/jobs.py c302470c76be290d3e715b1f9ac9214d2775924e 
  src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c 
  src/main/thrift/org/apache/aurora/gen/api.thrift c00f94371a27ffab41188b22f81bb1c8ec7a57e9 
  src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 0d51f7dc367081f72090736e36605bf363f3395e 
  src/test/python/apache/aurora/client/api/test_updater.py 720885ef1864f325346b7060b9aad2083665a7b1 
  src/test/python/apache/aurora/client/cli/test_diff.py 38629b63c082cf81cb891dace2a70d9e8f418e18 
  src/test/python/apache/aurora/client/cli/test_restart.py 92aefe612dd59df75188fd7fc8cf080c9a878dde 
  src/test/python/apache/aurora/client/cli/test_update.py 536d9c79d5a76a966ac175248b0a440b16f2d6b2 
  src/test/python/apache/aurora/client/commands/test_diff.py aa1e87fd60a8541a9f65f28f718f77d0e1cd5e3a 
  src/test/python/apache/aurora/client/commands/test_restart.py 0b71bbbdbb3058bd89e23d909efc6db1121d76b7 
  src/test/python/apache/aurora/client/commands/test_update.py 85b8423ab604d44406cb31000f63f8a45885296c 
  src/test/resources/org/apache/aurora/gen/api.thrift.md5 85de4b3e2915f7450ca9f88e2f3a875d9d821885 

Diff: https://reviews.apache.org/r/25455/diff/


Testing
-------

gradle -Pq build
./pants src/test/python:all


Thanks,

Maxim Khutornenko

Re: Review Request 25455: Deprecating PopulateJobResult.populated thrift field.

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25455/#review52671
-----------------------------------------------------------

Ship it!


- Bill Farner


On Sept. 8, 2014, 9:46 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25455/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2014, 9:46 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Deprecating PopulateJobResult.populated thrift field.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2 
>   src/main/python/apache/aurora/client/api/updater.py 927b646f32300301f4e0d286465140795faf3d54 
>   src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf 
>   src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c 
>   src/main/thrift/org/apache/aurora/gen/api.thrift c00f94371a27ffab41188b22f81bb1c8ec7a57e9 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 0d51f7dc367081f72090736e36605bf363f3395e 
>   src/test/python/apache/aurora/client/api/test_updater.py 720885ef1864f325346b7060b9aad2083665a7b1 
>   src/test/python/apache/aurora/client/cli/test_diff.py 38629b63c082cf81cb891dace2a70d9e8f418e18 
>   src/test/python/apache/aurora/client/cli/test_restart.py 92aefe612dd59df75188fd7fc8cf080c9a878dde 
>   src/test/python/apache/aurora/client/cli/test_update.py 8b7d11202b35deb09a0000248cfe0a96458fb70c 
>   src/test/python/apache/aurora/client/commands/test_diff.py aa1e87fd60a8541a9f65f28f718f77d0e1cd5e3a 
>   src/test/python/apache/aurora/client/commands/test_restart.py 0b71bbbdbb3058bd89e23d909efc6db1121d76b7 
>   src/test/python/apache/aurora/client/commands/test_update.py 85b8423ab604d44406cb31000f63f8a45885296c 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 85de4b3e2915f7450ca9f88e2f3a875d9d821885 
> 
> Diff: https://reviews.apache.org/r/25455/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>

Re: Review Request 25455: Deprecating PopulateJobResult.populated thrift field.

Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25455/#review52642
-----------------------------------------------------------

Ship it!


Ship It!

- Zameer Manji


On Sept. 8, 2014, 2:46 p.m., Maxim Khutornenko wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25455/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2014, 2:46 p.m.)
> 
> 
> Review request for Aurora, Bill Farner and Zameer Manji.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Deprecating PopulateJobResult.populated thrift field.
> 
> 
> Diffs
> -----
> 
>   src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java a43e5d7748c22d60f56f03a8a3d52949faebeff2 
>   src/main/python/apache/aurora/client/api/updater.py 927b646f32300301f4e0d286465140795faf3d54 
>   src/main/python/apache/aurora/client/cli/jobs.py 8f349c09637c16e2499e85f2dc96eb7ccffd0aaf 
>   src/main/python/apache/aurora/client/commands/core.py 1644f84b5887c2f8172789d82de00e6a735f5d0c 
>   src/main/thrift/org/apache/aurora/gen/api.thrift c00f94371a27ffab41188b22f81bb1c8ec7a57e9 
>   src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 0d51f7dc367081f72090736e36605bf363f3395e 
>   src/test/python/apache/aurora/client/api/test_updater.py 720885ef1864f325346b7060b9aad2083665a7b1 
>   src/test/python/apache/aurora/client/cli/test_diff.py 38629b63c082cf81cb891dace2a70d9e8f418e18 
>   src/test/python/apache/aurora/client/cli/test_restart.py 92aefe612dd59df75188fd7fc8cf080c9a878dde 
>   src/test/python/apache/aurora/client/cli/test_update.py 8b7d11202b35deb09a0000248cfe0a96458fb70c 
>   src/test/python/apache/aurora/client/commands/test_diff.py aa1e87fd60a8541a9f65f28f718f77d0e1cd5e3a 
>   src/test/python/apache/aurora/client/commands/test_restart.py 0b71bbbdbb3058bd89e23d909efc6db1121d76b7 
>   src/test/python/apache/aurora/client/commands/test_update.py 85b8423ab604d44406cb31000f63f8a45885296c 
>   src/test/resources/org/apache/aurora/gen/api.thrift.md5 85de4b3e2915f7450ca9f88e2f3a875d9d821885 
> 
> Diff: https://reviews.apache.org/r/25455/diff/
> 
> 
> Testing
> -------
> 
> gradle -Pq build
> ./pants src/test/python:all
> 
> 
> Thanks,
> 
> Maxim Khutornenko
> 
>