You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by Avery Ching <ac...@yahoo-inc.com> on 2011/08/30 06:48:14 UTC
Reviewboard for code reviews
Anyone know if we have reviewboard access?
Thanks,
Avery
Re: Reviewboard for code reviews
Posted by Avery Ching <ac...@yahoo-inc.com>.
Okay, let's make it optional for now. For me, it definitely helps to visualize the changes better. Also, I think the feedback tool is pretty good.
Avery
On Aug 30, 2011, at 11:52 AM, Henry Saputra wrote:
> Argh I meant "It should just an option to help review and should not
> be required for patches."
>
> - Henry
>
> On Tue, Aug 30, 2011 at 11:51 AM, Henry Saputra <he...@gmail.com> wrote:
>> +1
>>
>> It should just optional to help review not required.
>>
>> - Henry
>>
>> On Tue, Aug 30, 2011 at 11:48 AM, Jakob Homan <jg...@gmail.com> wrote:
>>> We've just gone around on this one for Kafka and, if reviewboard is
>>> provided, it would be good to keep it as an optional part of the
>>> process. I've had very negative experiences with it, both in Hadoop
>>> and Hive. If one would like to do a reviewboard review, that's great
>>> - but for those who don't, standard bullet points should suffice.
>>> -jakob
>>>
>>>
>>>
>>> On Tue, Aug 30, 2011 at 11:38 AM, Avery Ching <ac...@yahoo-inc.com> wrote:
>>>> Thanks Henry. I have filed issue
>>>>
>>>> https://issues.apache.org/jira/browse/INFRA-3892
>>>>
>>>> to get reviewboard access.
>>>>
>>>> Avery
>>>>
>>>> On Aug 30, 2011, at 11:35 AM, Henry Saputra wrote:
>>>>
>>>> Hi Avery, yes you should file INFRA ticket to add Giraph as Groups in
>>>> reviews board.
>>>>
>>>> I filed tickets to create one for Kafka and Gora.
>>>>
>>>> - Henry
>>>>
>>>> On Mon, Aug 29, 2011 at 10:13 PM, Avery Ching <ac...@yahoo-inc.com>> wrote:
>>>> https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the
>>>>
>>>> I'll file an INFRA ticket.
>>>>
>>>> Thanks,
>>>>
>>>> Avery
>>>>
>>>> On Aug 29, 2011, at 10:07 PM, Hyunsik Choi wrote:
>>>>
>>>> Looks possible. Some incubator project (e.g., Kafka) already has a
>>>> reviewboard group.
>>>>
>>>> Best regards,
>>>> --
>>>> Hyunsik Choi
>>>>
>>>>
>>>>
>>>> On Tue, Aug 30, 2011 at 1:48 PM, Avery Ching <ac...@yahoo-inc.com>> wrote:
>>>> Anyone know if we have reviewboard access?
>>>>
>>>> Thanks,
>>>>
>>>> Avery
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>>
Re: Reviewboard for code reviews
Posted by Henry Saputra <he...@gmail.com>.
Argh I meant "It should just an option to help review and should not
be required for patches."
- Henry
On Tue, Aug 30, 2011 at 11:51 AM, Henry Saputra <he...@gmail.com> wrote:
> +1
>
> It should just optional to help review not required.
>
> - Henry
>
> On Tue, Aug 30, 2011 at 11:48 AM, Jakob Homan <jg...@gmail.com> wrote:
>> We've just gone around on this one for Kafka and, if reviewboard is
>> provided, it would be good to keep it as an optional part of the
>> process. I've had very negative experiences with it, both in Hadoop
>> and Hive. If one would like to do a reviewboard review, that's great
>> - but for those who don't, standard bullet points should suffice.
>> -jakob
>>
>>
>>
>> On Tue, Aug 30, 2011 at 11:38 AM, Avery Ching <ac...@yahoo-inc.com> wrote:
>>> Thanks Henry. I have filed issue
>>>
>>> https://issues.apache.org/jira/browse/INFRA-3892
>>>
>>> to get reviewboard access.
>>>
>>> Avery
>>>
>>> On Aug 30, 2011, at 11:35 AM, Henry Saputra wrote:
>>>
>>> Hi Avery, yes you should file INFRA ticket to add Giraph as Groups in
>>> reviews board.
>>>
>>> I filed tickets to create one for Kafka and Gora.
>>>
>>> - Henry
>>>
>>> On Mon, Aug 29, 2011 at 10:13 PM, Avery Ching <ac...@yahoo-inc.com>> wrote:
>>> https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the
>>>
>>> I'll file an INFRA ticket.
>>>
>>> Thanks,
>>>
>>> Avery
>>>
>>> On Aug 29, 2011, at 10:07 PM, Hyunsik Choi wrote:
>>>
>>> Looks possible. Some incubator project (e.g., Kafka) already has a
>>> reviewboard group.
>>>
>>> Best regards,
>>> --
>>> Hyunsik Choi
>>>
>>>
>>>
>>> On Tue, Aug 30, 2011 at 1:48 PM, Avery Ching <ac...@yahoo-inc.com>> wrote:
>>> Anyone know if we have reviewboard access?
>>>
>>> Thanks,
>>>
>>> Avery
>>>
>>>
>>>
>>>
>>>
>>
>
Re: Reviewboard for code reviews
Posted by Henry Saputra <he...@gmail.com>.
+1
It should just optional to help review not required.
- Henry
On Tue, Aug 30, 2011 at 11:48 AM, Jakob Homan <jg...@gmail.com> wrote:
> We've just gone around on this one for Kafka and, if reviewboard is
> provided, it would be good to keep it as an optional part of the
> process. I've had very negative experiences with it, both in Hadoop
> and Hive. If one would like to do a reviewboard review, that's great
> - but for those who don't, standard bullet points should suffice.
> -jakob
>
>
>
> On Tue, Aug 30, 2011 at 11:38 AM, Avery Ching <ac...@yahoo-inc.com> wrote:
>> Thanks Henry. I have filed issue
>>
>> https://issues.apache.org/jira/browse/INFRA-3892
>>
>> to get reviewboard access.
>>
>> Avery
>>
>> On Aug 30, 2011, at 11:35 AM, Henry Saputra wrote:
>>
>> Hi Avery, yes you should file INFRA ticket to add Giraph as Groups in
>> reviews board.
>>
>> I filed tickets to create one for Kafka and Gora.
>>
>> - Henry
>>
>> On Mon, Aug 29, 2011 at 10:13 PM, Avery Ching <ac...@yahoo-inc.com>> wrote:
>> https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the
>>
>> I'll file an INFRA ticket.
>>
>> Thanks,
>>
>> Avery
>>
>> On Aug 29, 2011, at 10:07 PM, Hyunsik Choi wrote:
>>
>> Looks possible. Some incubator project (e.g., Kafka) already has a
>> reviewboard group.
>>
>> Best regards,
>> --
>> Hyunsik Choi
>>
>>
>>
>> On Tue, Aug 30, 2011 at 1:48 PM, Avery Ching <ac...@yahoo-inc.com>> wrote:
>> Anyone know if we have reviewboard access?
>>
>> Thanks,
>>
>> Avery
>>
>>
>>
>>
>>
>
Re: Reviewboard for code reviews
Posted by Jakob Homan <jg...@gmail.com>.
We've just gone around on this one for Kafka and, if reviewboard is
provided, it would be good to keep it as an optional part of the
process. I've had very negative experiences with it, both in Hadoop
and Hive. If one would like to do a reviewboard review, that's great
- but for those who don't, standard bullet points should suffice.
-jakob
On Tue, Aug 30, 2011 at 11:38 AM, Avery Ching <ac...@yahoo-inc.com> wrote:
> Thanks Henry. I have filed issue
>
> https://issues.apache.org/jira/browse/INFRA-3892
>
> to get reviewboard access.
>
> Avery
>
> On Aug 30, 2011, at 11:35 AM, Henry Saputra wrote:
>
> Hi Avery, yes you should file INFRA ticket to add Giraph as Groups in
> reviews board.
>
> I filed tickets to create one for Kafka and Gora.
>
> - Henry
>
> On Mon, Aug 29, 2011 at 10:13 PM, Avery Ching <ac...@yahoo-inc.com>> wrote:
> https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the
>
> I'll file an INFRA ticket.
>
> Thanks,
>
> Avery
>
> On Aug 29, 2011, at 10:07 PM, Hyunsik Choi wrote:
>
> Looks possible. Some incubator project (e.g., Kafka) already has a
> reviewboard group.
>
> Best regards,
> --
> Hyunsik Choi
>
>
>
> On Tue, Aug 30, 2011 at 1:48 PM, Avery Ching <ac...@yahoo-inc.com>> wrote:
> Anyone know if we have reviewboard access?
>
> Thanks,
>
> Avery
>
>
>
>
>
Re: Reviewboard for code reviews
Posted by Avery Ching <ac...@yahoo-inc.com>.
Thanks Henry. I have filed issue
https://issues.apache.org/jira/browse/INFRA-3892
to get reviewboard access.
Avery
On Aug 30, 2011, at 11:35 AM, Henry Saputra wrote:
Hi Avery, yes you should file INFRA ticket to add Giraph as Groups in
reviews board.
I filed tickets to create one for Kafka and Gora.
- Henry
On Mon, Aug 29, 2011 at 10:13 PM, Avery Ching <ac...@yahoo-inc.com>> wrote:
https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the
I'll file an INFRA ticket.
Thanks,
Avery
On Aug 29, 2011, at 10:07 PM, Hyunsik Choi wrote:
Looks possible. Some incubator project (e.g., Kafka) already has a
reviewboard group.
Best regards,
--
Hyunsik Choi
On Tue, Aug 30, 2011 at 1:48 PM, Avery Ching <ac...@yahoo-inc.com>> wrote:
Anyone know if we have reviewboard access?
Thanks,
Avery
Re: Reviewboard for code reviews
Posted by Henry Saputra <he...@gmail.com>.
Hi Avery, yes you should file INFRA ticket to add Giraph as Groups in
reviews board.
I filed tickets to create one for Kafka and Gora.
- Henry
On Mon, Aug 29, 2011 at 10:13 PM, Avery Ching <ac...@yahoo-inc.com> wrote:
> https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the
>
> I'll file an INFRA ticket.
>
> Thanks,
>
> Avery
>
> On Aug 29, 2011, at 10:07 PM, Hyunsik Choi wrote:
>
> Looks possible. Some incubator project (e.g., Kafka) already has a
> reviewboard group.
>
> Best regards,
> --
> Hyunsik Choi
>
>
>
> On Tue, Aug 30, 2011 at 1:48 PM, Avery Ching <ac...@yahoo-inc.com>> wrote:
> Anyone know if we have reviewboard access?
>
> Thanks,
>
> Avery
>
>
>
Re: Reviewboard for code reviews
Posted by Avery Ching <ac...@yahoo-inc.com>.
https://blogs.apache.org/infra/entry/reviewboard_instance_running_at_the
I'll file an INFRA ticket.
Thanks,
Avery
On Aug 29, 2011, at 10:07 PM, Hyunsik Choi wrote:
Looks possible. Some incubator project (e.g., Kafka) already has a
reviewboard group.
Best regards,
--
Hyunsik Choi
On Tue, Aug 30, 2011 at 1:48 PM, Avery Ching <ac...@yahoo-inc.com>> wrote:
Anyone know if we have reviewboard access?
Thanks,
Avery
Re: Reviewboard for code reviews
Posted by Hyunsik Choi <hy...@apache.org>.
Looks possible. Some incubator project (e.g., Kafka) already has a
reviewboard group.
Best regards,
--
Hyunsik Choi
On Tue, Aug 30, 2011 at 1:48 PM, Avery Ching <ac...@yahoo-inc.com> wrote:
> Anyone know if we have reviewboard access?
>
> Thanks,
>
> Avery
>