You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/03/12 09:24:26 UTC
[GitHub] [pulsar-test-infra] freeznet opened a new pull request #18: use GITHUB_REPOSITORY to make pulsarbot reusable
freeznet opened a new pull request #18:
URL: https://github.com/apache/pulsar-test-infra/pull/18
fix #17
This pr changes the default request URL from `https://api.github.com/repos/apache/pulsar` to `https://api.github.com/repos/${GITHUB_REPOSITORY}`, in order to make `pulsarbot` reusable to other repos like `apache/pulsar-client-go`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-test-infra] freeznet commented on a change in pull request #18: use GITHUB_REPOSITORY to make pulsarbot reusable
Posted by GitBox <gi...@apache.org>.
freeznet commented on a change in pull request #18:
URL: https://github.com/apache/pulsar-test-infra/pull/18#discussion_r594030255
##########
File path: pulsarbot/entrypoint.sh
##########
@@ -37,11 +37,11 @@ fi
PR_NUM=$(jq -r '.issue.number' "${GITHUB_EVENT_PATH}")
# get head sha
-curl -s -H "Accept: application/vnd.github.antiope-preview+json" https://api.github.com/repos/apache/pulsar/git/ref/pull/${PR_NUM}/head > result-headsha.txt
+curl -s -H "Accept: application/vnd.github.antiope-preview+json" "https://api.github.com/repos/${GITHUB_REPOSITORY}/git/ref/pull/${PR_NUM}/head" > result-headsha.txt
Review comment:
@zymap thanks for your review, added `BOT_TARGET_REPOSITORY` with default value `apache/pulsar`, PTAL.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-test-infra] zymap merged pull request #18: use GITHUB_REPOSITORY to make pulsarbot reusable
Posted by GitBox <gi...@apache.org>.
zymap merged pull request #18:
URL: https://github.com/apache/pulsar-test-infra/pull/18
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-test-infra] zymap commented on a change in pull request #18: use GITHUB_REPOSITORY to make pulsarbot reusable
Posted by GitBox <gi...@apache.org>.
zymap commented on a change in pull request #18:
URL: https://github.com/apache/pulsar-test-infra/pull/18#discussion_r594001302
##########
File path: pulsarbot/entrypoint.sh
##########
@@ -37,11 +37,11 @@ fi
PR_NUM=$(jq -r '.issue.number' "${GITHUB_EVENT_PATH}")
# get head sha
-curl -s -H "Accept: application/vnd.github.antiope-preview+json" https://api.github.com/repos/apache/pulsar/git/ref/pull/${PR_NUM}/head > result-headsha.txt
+curl -s -H "Accept: application/vnd.github.antiope-preview+json" "https://api.github.com/repos/${GITHUB_REPOSITORY}/git/ref/pull/${PR_NUM}/head" > result-headsha.txt
Review comment:
We need to add `apache/pulsar` as the default value otherwise this will break pulsar CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org