You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2022/08/12 05:40:05 UTC

[GitHub] [inlong] healchow commented on a diff in pull request #5492: [INLONG-5491][Manager] Fix pulsar failed to configure nonpartitioned topic problem

healchow commented on code in PR #5492:
URL: https://github.com/apache/inlong/pull/5492#discussion_r944128799


##########
inlong-manager/manager-service/src/main/java/org/apache/inlong/manager/service/resource/queue/pulsar/PulsarOperator.java:
##########
@@ -316,19 +321,29 @@ public boolean topicIsExists(PulsarAdmin pulsarAdmin, String tenant, String name
         return topicExists;
     }
 
-    private boolean subscriptionIsExists(PulsarAdmin pulsarAdmin, String topic, String subscription) {
+    private boolean subscriptionIsExists(PulsarAdmin pulsarAdmin, PulsarTopicBean topicBean, String subscription) {

Review Comment:
   It is recommended to pass in a field of whether it is a partitioned topic.
   Such as `boolean isPartitionedTopic`.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org