[GitHub] [cloudstack] ravening commented on pull request #4636: Prevent vm's from stopping while enabling maintenance mode

[GitBox <gi...@apache.org>]

ravening commented on pull request #4636:
URL: https://github.com/apache/cloudstack/pull/4636#issuecomment-925565859


   > > Been trying to reproduce the issue but couldn't, pinging @rhtyd @weizhouapache @sureshanaparti the changes makes sense however I could not reproduce the failure to test the fix, please advise if you figure out a way to reproduce it
   > 
   > @nvazquez What steps you tried to reproduce it? May be, keep as many VMs possible in a host, and try rebooting host / disconnecting host agent as soon as maintenance is enabled. @ravening can you confirm on how to reproduce / verify this?
   
   @sureshanaparti @nvazquez this issue mostly happens when you try to enable maintenance mode on the host but it fails to enter the maintenance mode and rathen it goes into disconnected state. In that case vm's will be stopped as they cant be reached through agent.
   
   Im ok to close this pr, if it cant be reproduced


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org