You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/06/08 12:29:38 UTC

[GitHub] [skywalking-python] tom-pytel opened a new pull request #123: fix module wrapt as normal install dependancy

tom-pytel opened a new pull request #123:
URL: https://github.com/apache/skywalking-python/pull/123


   Added this to `requirements.txt` in the plugin PR but forgot `setup.py` so test worked due to `requirements.txt` but normal install did not. Also even though this module is only used for `psycog2` currently it will be a necessity for instrumenting any future modules which use C extension objects.
   
   P.S. Do I need to do anything else milestone-wise than just add it to Milestone 0.7.0 here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] tom-pytel merged pull request #123: fix module wrapt as normal install dependancy

Posted by GitBox <gi...@apache.org>.
tom-pytel merged pull request #123:
URL: https://github.com/apache/skywalking-python/pull/123


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking-python] kezhenxu94 commented on pull request #123: fix module wrapt as normal install dependancy

Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on pull request #123:
URL: https://github.com/apache/skywalking-python/pull/123#issuecomment-856766017


   > P.S. Do I need to do anything else milestone-wise than just add it to Milestone 0.7.0 here?
   
   Adding it to the current milestone is enough. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org