You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/11/17 01:29:48 UTC
[GitHub] [apisix] spacewander opened a new pull request #2768: ci: make it work under OpenResty 1.19
spacewander opened a new pull request #2768:
URL: https://github.com/apache/apisix/pull/2768
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
<!--- If it fixes an open issue, please link to the issue here. -->
### Pre-submission checklist:
* [ ] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [ ] Is this PR backward compatible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on pull request #2768: ci: make it work under OpenResty 1.19
Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #2768:
URL: https://github.com/apache/apisix/pull/2768#issuecomment-730828820
It seems that these changes are only suitable for 1.19.
Do we need to test under 1.18 at the same time?
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #2768: ci: make it work under OpenResty 1.19
Posted by GitBox <gi...@apache.org>.
spacewander commented on pull request #2768:
URL: https://github.com/apache/apisix/pull/2768#issuecomment-730950271
@membphis
Maybe we should disable the outdated check in the protected branch settings of the repository settings? See:
https://github.community/t/github-actions-pull-requests-always-include-some-outdated-checks/16157/2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #2768: ci: make it work under OpenResty 1.19
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #2768:
URL: https://github.com/apache/apisix/pull/2768#discussion_r527470041
##########
File path: t/node/upstream-node-dns.t
##########
@@ -253,20 +253,27 @@ location /t {
GET /t
--- grep_error_log eval
qr/dns resolver domain: \w+.com to 127.0.0.\d|call \/hello|proxy request to 127.0.0.\d:1980/
---- grep_error_log_out
-call /hello
+--- grep_error_log_out eval
Review comment:
@membphis
Yes. The dns resolver order is different in OpenResty 1.19.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #2768: ci: make it work under OpenResty 1.19
Posted by GitBox <gi...@apache.org>.
membphis commented on pull request #2768:
URL: https://github.com/apache/apisix/pull/2768#issuecomment-730912304
I do not know why the status is `waiting for ... reported`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #2768: ci: make it work under OpenResty 1.19
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #2768:
URL: https://github.com/apache/apisix/pull/2768#discussion_r527375571
##########
File path: t/node/upstream-node-dns.t
##########
@@ -519,22 +533,29 @@ location /t {
GET /t
--- grep_error_log eval
qr/dns resolver domain: \w+.com to 127.0.0.\d|call \/hello|proxy request to 127.0.0.\d:1980/
---- grep_error_log_out
-call /hello
-dns resolver domain: test2.com to 127.0.0.1
+--- grep_error_log_out eval
Review comment:
ditoo
##########
File path: t/node/upstream-node-dns.t
##########
@@ -253,20 +253,27 @@ location /t {
GET /t
--- grep_error_log eval
qr/dns resolver domain: \w+.com to 127.0.0.\d|call \/hello|proxy request to 127.0.0.\d:1980/
---- grep_error_log_out
-call /hello
+--- grep_error_log_out eval
Review comment:
Why does this change? Is it also because of openresty 1.19. *?
##########
File path: t/plugin/example.t
##########
@@ -200,7 +200,7 @@ qr/module 'apisix.plugins.not-exist-plugin' not found/
modifiedIndex = 1,
})
- local encode_json = require "cjson.safe" .encode
+ local encode_json = require "toolkit.json" .encode
Review comment:
ditto
##########
File path: t/plugin/example.t
##########
@@ -149,7 +149,7 @@ done
ngx.say("failed to load plugins: ", err)
end
- local encode_json = require "cjson.safe" .encode
+ local encode_json = require "toolkit.json" .encode
Review comment:
`require("toolkit.json").encode`
I think this style is easier to understand
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #2768: CI: make it work under OpenResty 1.19
Posted by GitBox <gi...@apache.org>.
spacewander commented on a change in pull request #2768:
URL: https://github.com/apache/apisix/pull/2768#discussion_r527375788
##########
File path: t/lib/server.lua
##########
@@ -357,6 +357,7 @@ function _M.log()
ngx.req.read_body()
local body = ngx.req.get_body_data()
local ct = ngx.var.content_type
+ print(ct)
Review comment:
@nic-chen
Fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] moonming merged pull request #2768: ci: make it work under OpenResty 1.19
Posted by GitBox <gi...@apache.org>.
moonming merged pull request #2768:
URL: https://github.com/apache/apisix/pull/2768
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] nic-chen commented on a change in pull request #2768: ci: make it work under OpenResty 1.19
Posted by GitBox <gi...@apache.org>.
nic-chen commented on a change in pull request #2768:
URL: https://github.com/apache/apisix/pull/2768#discussion_r527371117
##########
File path: t/lib/server.lua
##########
@@ -357,6 +357,7 @@ function _M.log()
ngx.req.read_body()
local body = ngx.req.get_body_data()
local ct = ngx.var.content_type
+ print(ct)
Review comment:
is it a debug?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org