[GitHub] spark pull request: [SPARK-8728] Add configuration for limiting th...

[andrewor14 <gi...@git.apache.org>]

Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7119#discussion_r38492570
  
    --- Diff: core/src/main/scala/org/apache/spark/scheduler/Pool.scala ---
    @@ -97,8 +99,14 @@ private[spark] class Pool(
     
       override def getSortedTaskSetQueue: ArrayBuffer[TaskSetManager] = {
         var sortedTaskSetQueue = new ArrayBuffer[TaskSetManager]
    +    def targetSchedulables = { sq:ConcurrentLinkedQueue[Schedulable] =>
    +      if (maxRunning != 0)
    +        sq.take(maxRunning).toSeq
    +      else
    +        sq.toSeq
    +    }
    --- End diff --
    
    this is only used once so it can be a val:
    ```
    val targetSchedulables =
      if (maxRunning != 0) {
        schedulableQueue.take(maxRunning).toSeq
      } else {
        schedulableQueue.toSeq
      }
    val sortedSchedulableQueue = targetSchedulables.sortWith(...)
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org