You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@openoffice.apache.org by TJ Frazier <tj...@cfl.rr.com> on 2011/09/10 21:12:12 UTC
Re: svn commit: r1167563 - /incubator/ooo/trunk/main/vcl/Library_vcl.mk
On 9/10/2011 13:35, erack@apache.org wrote:
> Author: erack
> Date: Sat Sep 10 17:35:58 2011
> New Revision: 1167563
>
> URL: http://svn.apache.org/viewvc?rev=1167563&view=rev
> Log:
> ooo34gsl01: #i117680# add ADAPT_EXT_STL define as was before gnumake conversion
>
> # User Philipp Lohmann [pl]<Ph...@oracle.com>
>
> Modified:
> incubator/ooo/trunk/main/vcl/Library_vcl.mk
>
> Modified: incubator/ooo/trunk/main/vcl/Library_vcl.mk
> URL: http://svn.apache.org/viewvc/incubator/ooo/trunk/main/vcl/Library_vcl.mk?rev=1167563&r1=1167562&r2=1167563&view=diff
> ==============================================================================
> --- incubator/ooo/trunk/main/vcl/Library_vcl.mk (original)
> +++ incubator/ooo/trunk/main/vcl/Library_vcl.mk Sat Sep 10 17:35:58 2011
> @@ -427,6 +427,17 @@ $(eval $(call gb_Library_add_exception_o
> vcl/source/glyphs/graphite_layout \
> vcl/source/glyphs/graphite_textsrc \
> ))
> +
> +#building with stlport, but graphite was not built with stlport
> +ifneq ($(USE_SYSTEM_STL),YES)
***> +ifeq ($(SYSTEM_GRPAHITE),YES)
> +$(eval $(call gb_Library_set_defs,vcl,\
> + $$(DEFS) \
> + -DADAPT_EXT_STL \
> +))
> +endif
> +endif
> +
> # handle X11 platforms, which have additional files and possibly system graphite
> ifeq ($(GUIBASE),unx)
> $(eval $(call gb_Library_add_exception_objects,vcl,\
>
Typo warning: s/GRPAHITE/GRAPHITE/
--
/tj/
Re: svn commit: r1167563 - /incubator/ooo/trunk/main/vcl/Library_vcl.mk
Posted by TJ Frazier <tj...@cfl.rr.com>.
On 9/10/2011 15:31, Eike Rathke wrote:
> Hi TJ,
>
> On Saturday, 2011-09-10 15:12:12 -0400, TJ Frazier wrote:
>
>> ***> +ifeq ($(SYSTEM_GRPAHITE),YES)
>> Typo warning: s/GRPAHITE/GRAPHITE/
>
> Thanks for proofreading commits :)
> http://svn.apache.org/viewvc?view=revision&revision=1167581
>
> Eike
>
Welcome. It's kind of fun for my jelly-ware compiler, to guess what
language it's working on.
BTW, I'm glad the author of those if( ... && ... ) statements is
confident of the operator precedence. I always need an extra set of
parentheses: extra effort, always; messier look, always; works, always ...
--
/tj/
Re: svn commit: r1167563 -
/incubator/ooo/trunk/main/vcl/Library_vcl.mk
Posted by Eike Rathke <oo...@erack.de>.
Hi TJ,
On Saturday, 2011-09-10 15:12:12 -0400, TJ Frazier wrote:
> ***> +ifeq ($(SYSTEM_GRPAHITE),YES)
> Typo warning: s/GRPAHITE/GRAPHITE/
Thanks for proofreading commits :)
http://svn.apache.org/viewvc?view=revision&revision=1167581
Eike
--
PGP/OpenPGP/GnuPG encrypted mail preferred in all private communication.
Key ID: 0x293C05FD - 997A 4C60 CE41 0149 0DB3 9E96 2F1A D073 293C 05FD