You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Jens-G <gi...@git.apache.org> on 2014/12/14 00:39:09 UTC

[GitHub] thrift pull request: THRIFT-2890 binary data may lose bytes with J...

GitHub user Jens-G opened a pull request:

    https://github.com/apache/thrift/pull/319

    THRIFT-2890 binary data may lose bytes with JSON transport under specifi...

    ...c circumstances
    
    Client: Delphi
    Patch: Jens Geyer
    
    This patch consists of a ported version of the base64 encoding/decoding used in C#. It handles the above case correctly, decodes data more efficiently in-place, and removes the dependency to Indy (IdCoderMIME).

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Jens-G/thrift thrift-2890

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #319
    
----
commit fc8c93b16c8c936069685f908dcd54c30bd479cc
Author: Jens Geyer <je...@apache.org>
Date:   2014-12-13T22:44:23Z

    THRIFT-2890 binary data may lose bytes with JSON transport under specific circumstances
    Client: Delphi
    Patch: Jens Geyer
    
    This patch consists of a ported version of the base64 encoding/decoding used in C#. It handles the above case correctly, decodes data more efficiently in-place, and removes the dependency to Indy (IdCoderMIME).

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: THRIFT-2890 binary data may lose bytes with J...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/thrift/pull/319


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---