You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/02/06 21:41:13 UTC
[GitHub] [airflow] dimberman opened a new pull request #14117: Fix KubernetesPodOperator test broken by 14083
dimberman opened a new pull request #14117:
URL: https://github.com/apache/airflow/pull/14117
Fixes a test that was broken because the test k8s.V1EnvVar did not have
a template_fields field.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #14117: Fix KubernetesPodOperator test broken by 14083
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #14117:
URL: https://github.com/apache/airflow/pull/14117#issuecomment-774672887
The test is still failing 🤔
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jhtimmins commented on pull request #14117: Fix KubernetesPodOperator test broken by 14083
Posted by GitBox <gi...@apache.org>.
jhtimmins commented on pull request #14117:
URL: https://github.com/apache/airflow/pull/14117#issuecomment-774588076
Aside from the failing test, this looks good to go
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman closed pull request #14117: Fix KubernetesPodOperator test broken by 14083
Posted by GitBox <gi...@apache.org>.
dimberman closed pull request #14117:
URL: https://github.com/apache/airflow/pull/14117
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dimberman commented on pull request #14117: Fix KubernetesPodOperator test broken by 14083
Posted by GitBox <gi...@apache.org>.
dimberman commented on pull request #14117:
URL: https://github.com/apache/airflow/pull/14117#issuecomment-774592837
Thank you @jhtimmins, luckily looks like the failing test caught a bug if the env_vars was empty :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org