[GitHub] [couchdb] tonysun83 commented on pull request #3416: Prometheus endpoint

[GitBox <gi...@apache.org>]

tonysun83 commented on pull request #3416:
URL: https://github.com/apache/couchdb/pull/3416#issuecomment-807907979


   @chewbranca 
   
   Those were my exact thoughts when I was writing this up as having an app/gen_server was a bit of overkill. The bulk of the code is in the wrapper which does the conversion so it wouldn't make sense to add the extra supervision tree. The two reasons of adding it however were 1) We're going to add _active_task info as well later on and I didn't want to have a huge chunk of code inside chttpd_node to combine 3 different sources of stats info (stats, system, active_tasks) as it'll get messier.  2) The addition of the mochiweb_server was the deciding factor as now we needed a separate process to linger around. Even though it's optional, I'd rather not have a non-supervised mochiweb server lingering in the vm.
   
   The reason for the mochiweb_server was to bypass the need to have a username/password in certain situations. One of those situations that arose was the need to store credentials inside a Prometheus config file. It was an internal scrape but forcing the storage of credentials meant additional security parameters in place such that the credentials would not leak. It would be more secure in that scenario not to use credentials. Thus, it's configurable and OFF by default. Would love some additional thoughts on this cc @janl @wohali.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org