[GitHub] [superset] adam-stasiak commented on pull request #12619: fix: Set a unique savedMetricId when adding a new saved metric to controls

[GitBox <gi...@apache.org>]

adam-stasiak commented on pull request #12619:
URL: https://github.com/apache/superset/pull/12619#issuecomment-763959792


   I saw in console warning related to this PR:
   To reproduce:
   Add metric
   Set Custom name for this
   Save chart and revisit page 
   
   ```Warning: Failed prop type: The prop `savedMetric.metric_name` is marked as required in `AdhocMetricOption`, but its value is `undefined`.
       in AdhocMetricOption (at MetricDefinitionValue.jsx:80)
       in MetricDefinitionValue (at MetricsControl.jsx:126)
       in div (created by Context.Consumer)
       in Styled(div) (at MetricsControl.jsx:380)
       in div (at MetricsControl.jsx:363)
       in MetricsControl (created by Context.Consumer)
       in WithTheme(MetricsControl) (created by DragDropContext(WithTheme(MetricsControl)))
       in DragDropContext(WithTheme(MetricsControl)) (at Control.tsx:42)
       in div (at Control.tsx:41)
       in Control (at ControlPanelsContainer.jsx:125)
       in div (at ControlRow.jsx:33)
       in div (at ControlRow.jsx:31)
       in ControlSetRow (at ControlPanelsContainer.jsx:182)
       in div (created by PanelBody)
       in PanelBody (at ControlPanelSection.jsx:109)
       in div (created by PanelCollapse)
       in Transition (created by Collapse)
       in Collapse (created by PanelCollapse)
       in PanelCollapse (at ControlPanelSection.jsx:108)
       in div (created by Panel)
       in Panel (created by Uncontrolled(Panel))
       in Uncontrolled(Panel) (created by ForwardRef)
       in ForwardRef (at ControlPanelSection.jsx:100)
       in ControlPanelSection (at ControlPanelsContainer.jsx:149)
       in div (created by TabPane)
       in TabPane (created by Context.Consumer)
       in Styled(TabPane) (at ControlPanelsContainer.jsx:245)
       in div (created by TabPanelList)
       in div (created by TabPanelList)
       in TabPanelList (created by ForwardRef(Tabs))
       in div (created by ForwardRef(Tabs))
       in ForwardRef(Tabs) (created by Tabs)
       in Tabs (created by Context.Consumer)
       in Styled(Tabs) (at ControlPanelsContainer.jsx:240)
       in div (created by Context.Consumer)
       in Styled(div) (at ControlPanelsContainer.jsx:226)
       in ControlPanelsContainer (created by ConnectFunction)
       in ConnectFunction (at ExploreViewContainer.jsx:475)
       in div (created by Resizable)
       in Resizable (at ExploreViewContainer.jsx:458)
       in div (created by Context.Consumer)
       in Styled(div) (at ExploreViewContainer.jsx:373)
       in ExploreViewContainer (created by ConnectFunction)
       in ConnectFunction (at App.jsx:38)
       in DynamicPluginProvider (at App.jsx:37)
       in ThemeProvider (at App.jsx:36)
       in Provider (at App.jsx:35)
       in App (created by HotExportedApp)
       in AppContainer (created by HotExportedApp)
       in HotExportedApp (at explore/index.jsx:59)```
       
       


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org