You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "LinMingQiang (via GitHub)" <gi...@apache.org> on 2024/06/07 06:59:45 UTC
[PR] [flink] Add parameter isEndInput for Committer to distinguish batch o… [paimon]
LinMingQiang opened a new pull request, #3486:
URL: https://github.com/apache/paimon/pull/3486
…r streaming mode.
<!-- Please specify the module before the PR name: [core] ... or [flink] ... -->
### Purpose
<!-- Linking this pull request to the issue -->
Linked issue: https://github.com/apache/paimon/issues/3434
<!-- What is the purpose of the change -->
### Tests
<!-- List UT and IT cases to verify this change -->
### API and Format
<!-- Does this change affect API or storage format -->
### Documentation
<!-- Does this change introduce a new feature -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Add parameter isEndInput for Committer to distinguish batch o… [paimon]
Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on PR #3486:
URL: https://github.com/apache/paimon/pull/3486#issuecomment-2154417591
Yeah,you were right,thanks for the advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Add parameter isEndInput for committer and forcing check expire while endInput. [paimon]
Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on PR #3486:
URL: https://github.com/apache/paimon/pull/3486#issuecomment-2173594076
@JingsongLi I add a procedure to execute expire partitions. cc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Add parameter isEndInput for Committer to distinguish batch o… [paimon]
Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on PR #3486:
URL: https://github.com/apache/paimon/pull/3486#issuecomment-2154246664
@JingsongLi Do you have time to review this pr for me? thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Add parameter isEndInput for committer and forcing check expire while endInput. [paimon]
Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on PR #3486:
URL: https://github.com/apache/paimon/pull/3486#issuecomment-2172554259
Yes, I have considered this question before,performing partition filtering every time is a costly operation. And i will try your advice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Add parameter isEndInput for committer and forcing check expire while endInput. [paimon]
Posted by "LinMingQiang (via GitHub)" <gi...@apache.org>.
LinMingQiang commented on PR #3486:
URL: https://github.com/apache/paimon/pull/3486#issuecomment-2162678144
@JingsongLi Do you have time to review this pr for me? Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [flink] Add parameter isEndInput for Committer to distinguish batch o… [paimon]
Posted by "leaves12138 (via GitHub)" <gi...@apache.org>.
leaves12138 commented on PR #3486:
URL: https://github.com/apache/paimon/pull/3486#issuecomment-2154392100
I think `TableCommitImpl` in paimon-core does not need to know if it is endInput, just need to know it should force expire.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org