You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/10/14 23:04:33 UTC
[jira] Created: (CASSANDRA-1619) improve cli list command
improve cli list command
------------------------
Key: CASSANDRA-1619
URL: https://issues.apache.org/jira/browse/CASSANDRA-1619
Project: Cassandra
Issue Type: Improvement
Components: Tools
Affects Versions: 0.7.0
Reporter: Jonathan Ellis
Fix For: 0.7.0
* "list CF" without arguments should assume start_key=end_key=''
* default limit should be 100, not Integer.MAX_VALUE
* list CF[...][column] should be applicable to normal columns as well as super, for consistency w/ get
* limit clause doesn't work:
{code}
[default@Keyspace1] list CF2['':''] limit 2
Exception in thread "main" java.lang.AssertionError
at org.apache.cassandra.cli.CliClient.executeList(CliClient.java:1087)
at org.apache.cassandra.cli.CliClient.executeCLIStmt(CliClient.java:150)
at org.apache.cassandra.cli.CliMain.processCLIStmt(CliMain.java:227)
at org.apache.cassandra.cli.CliMain.main(CliMain.java:300)
{code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1619) improve cli list command
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1619:
--------------------------------------
Attachment: 1619-v2.txt
v2 attached w/ some cleanup of the limit code.
still doesn't allow "list CF" w/ no brackets, is that possible?
doesn't apply column name to slicepredicate in non-super case, we should do that.
> improve cli list command
> ------------------------
>
> Key: CASSANDRA-1619
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1619
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 0.7.0
> Reporter: Jonathan Ellis
> Assignee: Jim Ancona
> Fix For: 0.7.0
>
> Attachments: 1619-v2.txt, cassandra-list-improvements.patch
>
>
> * "list CF" without arguments should assume start_key=end_key=''
> * default limit should be 100, not Integer.MAX_VALUE
> * list CF[...][column] should be applicable to normal columns as well as super, for consistency w/ get
> * limit clause doesn't work:
> {code}
> [default@Keyspace1] list CF2['':''] limit 2
> Exception in thread "main" java.lang.AssertionError
> at org.apache.cassandra.cli.CliClient.executeList(CliClient.java:1087)
> at org.apache.cassandra.cli.CliClient.executeCLIStmt(CliClient.java:150)
> at org.apache.cassandra.cli.CliMain.processCLIStmt(CliMain.java:227)
> at org.apache.cassandra.cli.CliMain.main(CliMain.java:300)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1619) improve cli list command
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921581#action_12921581 ]
Jonathan Ellis commented on CASSANDRA-1619:
-------------------------------------------
... hopefully we can re-use the SlicePredicate and ColumnParent creation code between GET and LIST.
> improve cli list command
> ------------------------
>
> Key: CASSANDRA-1619
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1619
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 0.7.0
> Reporter: Jonathan Ellis
> Assignee: Jim Ancona
> Fix For: 0.7.0
>
> Attachments: 1619-v2.txt, cassandra-list-improvements.patch
>
>
> * "list CF" without arguments should assume start_key=end_key=''
> * default limit should be 100, not Integer.MAX_VALUE
> * list CF[...][column] should be applicable to normal columns as well as super, for consistency w/ get
> * limit clause doesn't work:
> {code}
> [default@Keyspace1] list CF2['':''] limit 2
> Exception in thread "main" java.lang.AssertionError
> at org.apache.cassandra.cli.CliClient.executeList(CliClient.java:1087)
> at org.apache.cassandra.cli.CliClient.executeCLIStmt(CliClient.java:150)
> at org.apache.cassandra.cli.CliMain.processCLIStmt(CliMain.java:227)
> at org.apache.cassandra.cli.CliMain.main(CliMain.java:300)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1619) improve cli list command
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921580#action_12921580 ]
Jonathan Ellis commented on CASSANDRA-1619:
-------------------------------------------
bq. WRT making list CF[...][column] applicable to normal columns as well as super, should we also support list[...][super][col]
We should support what GET supports. So, yes.
> improve cli list command
> ------------------------
>
> Key: CASSANDRA-1619
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1619
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 0.7.0
> Reporter: Jonathan Ellis
> Assignee: Jim Ancona
> Fix For: 0.7.0
>
> Attachments: 1619-v2.txt, cassandra-list-improvements.patch
>
>
> * "list CF" without arguments should assume start_key=end_key=''
> * default limit should be 100, not Integer.MAX_VALUE
> * list CF[...][column] should be applicable to normal columns as well as super, for consistency w/ get
> * limit clause doesn't work:
> {code}
> [default@Keyspace1] list CF2['':''] limit 2
> Exception in thread "main" java.lang.AssertionError
> at org.apache.cassandra.cli.CliClient.executeList(CliClient.java:1087)
> at org.apache.cassandra.cli.CliClient.executeCLIStmt(CliClient.java:150)
> at org.apache.cassandra.cli.CliMain.processCLIStmt(CliMain.java:227)
> at org.apache.cassandra.cli.CliMain.main(CliMain.java:300)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (CASSANDRA-1619) improve cli list command
Posted by "Jim Ancona (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Ancona reassigned CASSANDRA-1619:
-------------------------------------
Assignee: Jim Ancona
> improve cli list command
> ------------------------
>
> Key: CASSANDRA-1619
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1619
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 0.7.0
> Reporter: Jonathan Ellis
> Assignee: Jim Ancona
> Fix For: 0.7.0
>
>
> * "list CF" without arguments should assume start_key=end_key=''
> * default limit should be 100, not Integer.MAX_VALUE
> * list CF[...][column] should be applicable to normal columns as well as super, for consistency w/ get
> * limit clause doesn't work:
> {code}
> [default@Keyspace1] list CF2['':''] limit 2
> Exception in thread "main" java.lang.AssertionError
> at org.apache.cassandra.cli.CliClient.executeList(CliClient.java:1087)
> at org.apache.cassandra.cli.CliClient.executeCLIStmt(CliClient.java:150)
> at org.apache.cassandra.cli.CliMain.processCLIStmt(CliMain.java:227)
> at org.apache.cassandra.cli.CliMain.main(CliMain.java:300)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1619) improve cli list command
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12923469#action_12923469 ]
Hudson commented on CASSANDRA-1619:
-----------------------------------
Integrated in Cassandra #572 (See [https://hudson.apache.org/hudson/job/Cassandra/572/])
remove supercolumn option from cli list command; clean up grammar and fix limit support.
patch by jbellis and Jim Ancona for CASSANDRA-1619
> improve cli list command
> ------------------------
>
> Key: CASSANDRA-1619
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1619
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 0.7.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.7.0
>
> Attachments: 1619-v2.txt, 1619-v3.txt, cassandra-list-improvements.patch
>
>
> * "list CF" without arguments should assume start_key=end_key=''
> * default limit should be 100, not Integer.MAX_VALUE
> * list CF[...][column] should be applicable to normal columns as well as super, for consistency w/ get
> * limit clause doesn't work:
> {code}
> [default@Keyspace1] list CF2['':''] limit 2
> Exception in thread "main" java.lang.AssertionError
> at org.apache.cassandra.cli.CliClient.executeList(CliClient.java:1087)
> at org.apache.cassandra.cli.CliClient.executeCLIStmt(CliClient.java:150)
> at org.apache.cassandra.cli.CliMain.processCLIStmt(CliMain.java:227)
> at org.apache.cassandra.cli.CliMain.main(CliMain.java:300)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1619) improve cli list command
Posted by "Jim Ancona (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jim Ancona updated CASSANDRA-1619:
----------------------------------
Attachment: cassandra-list-improvements.patch
> improve cli list command
> ------------------------
>
> Key: CASSANDRA-1619
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1619
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 0.7.0
> Reporter: Jonathan Ellis
> Assignee: Jim Ancona
> Fix For: 0.7.0
>
> Attachments: cassandra-list-improvements.patch
>
>
> * "list CF" without arguments should assume start_key=end_key=''
> * default limit should be 100, not Integer.MAX_VALUE
> * list CF[...][column] should be applicable to normal columns as well as super, for consistency w/ get
> * limit clause doesn't work:
> {code}
> [default@Keyspace1] list CF2['':''] limit 2
> Exception in thread "main" java.lang.AssertionError
> at org.apache.cassandra.cli.CliClient.executeList(CliClient.java:1087)
> at org.apache.cassandra.cli.CliClient.executeCLIStmt(CliClient.java:150)
> at org.apache.cassandra.cli.CliMain.processCLIStmt(CliMain.java:227)
> at org.apache.cassandra.cli.CliMain.main(CliMain.java:300)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1619) improve cli list command
Posted by "Jim Ancona (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921574#action_12921574 ]
Jim Ancona commented on CASSANDRA-1619:
---------------------------------------
Oops, cross-posted comments. I'll look at your patch and try to add the additional functionality this weekend.
> improve cli list command
> ------------------------
>
> Key: CASSANDRA-1619
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1619
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 0.7.0
> Reporter: Jonathan Ellis
> Assignee: Jim Ancona
> Fix For: 0.7.0
>
> Attachments: 1619-v2.txt, cassandra-list-improvements.patch
>
>
> * "list CF" without arguments should assume start_key=end_key=''
> * default limit should be 100, not Integer.MAX_VALUE
> * list CF[...][column] should be applicable to normal columns as well as super, for consistency w/ get
> * limit clause doesn't work:
> {code}
> [default@Keyspace1] list CF2['':''] limit 2
> Exception in thread "main" java.lang.AssertionError
> at org.apache.cassandra.cli.CliClient.executeList(CliClient.java:1087)
> at org.apache.cassandra.cli.CliClient.executeCLIStmt(CliClient.java:150)
> at org.apache.cassandra.cli.CliMain.processCLIStmt(CliMain.java:227)
> at org.apache.cassandra.cli.CliMain.main(CliMain.java:300)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1619) improve cli list command
Posted by "Jim Ancona (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921572#action_12921572 ]
Jim Ancona commented on CASSANDRA-1619:
---------------------------------------
The attached patch addresses most of Jonathan's issues.
* {{list CF[]}} now defaults the start and end keys to ''. Also {{list CF['key1':]}} will default the end key to ''.
* Default limit is now 100
* {{limit}} clause works, although it always did for me. Please report any further problems.
* When a limit is used, the rows returned message includes the suffix "(out of N)" where N is the the number that would have been returned without the LIMIT
Question: WRT making list CF[...][column] applicable to normal columns as well as super, should we also support list[...][super][col] also?
> improve cli list command
> ------------------------
>
> Key: CASSANDRA-1619
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1619
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 0.7.0
> Reporter: Jonathan Ellis
> Assignee: Jim Ancona
> Fix For: 0.7.0
>
> Attachments: 1619-v2.txt, cassandra-list-improvements.patch
>
>
> * "list CF" without arguments should assume start_key=end_key=''
> * default limit should be 100, not Integer.MAX_VALUE
> * list CF[...][column] should be applicable to normal columns as well as super, for consistency w/ get
> * limit clause doesn't work:
> {code}
> [default@Keyspace1] list CF2['':''] limit 2
> Exception in thread "main" java.lang.AssertionError
> at org.apache.cassandra.cli.CliClient.executeList(CliClient.java:1087)
> at org.apache.cassandra.cli.CliClient.executeCLIStmt(CliClient.java:150)
> at org.apache.cassandra.cli.CliMain.processCLIStmt(CliMain.java:227)
> at org.apache.cassandra.cli.CliMain.main(CliMain.java:300)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-1619) improve cli list command
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12921123#action_12921123 ]
Jonathan Ellis commented on CASSANDRA-1619:
-------------------------------------------
Also, when the default limit is used, we should print out a warning to that effect.
> improve cli list command
> ------------------------
>
> Key: CASSANDRA-1619
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1619
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 0.7.0
> Reporter: Jonathan Ellis
> Fix For: 0.7.0
>
>
> * "list CF" without arguments should assume start_key=end_key=''
> * default limit should be 100, not Integer.MAX_VALUE
> * list CF[...][column] should be applicable to normal columns as well as super, for consistency w/ get
> * limit clause doesn't work:
> {code}
> [default@Keyspace1] list CF2['':''] limit 2
> Exception in thread "main" java.lang.AssertionError
> at org.apache.cassandra.cli.CliClient.executeList(CliClient.java:1087)
> at org.apache.cassandra.cli.CliClient.executeCLIStmt(CliClient.java:150)
> at org.apache.cassandra.cli.CliMain.processCLIStmt(CliMain.java:227)
> at org.apache.cassandra.cli.CliMain.main(CliMain.java:300)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (CASSANDRA-1619) improve cli list command
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-1619.
---------------------------------------
Resolution: Fixed
Assignee: Jonathan Ellis (was: Jim Ancona)
committed v3 which fixes limit and removes supercolumn support since it's problematic as described above. unless someone gets a patch in the next day i'm happy to omit that for 0.7.0.
> improve cli list command
> ------------------------
>
> Key: CASSANDRA-1619
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1619
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 0.7.0
> Reporter: Jonathan Ellis
> Assignee: Jonathan Ellis
> Fix For: 0.7.0
>
> Attachments: 1619-v2.txt, 1619-v3.txt, cassandra-list-improvements.patch
>
>
> * "list CF" without arguments should assume start_key=end_key=''
> * default limit should be 100, not Integer.MAX_VALUE
> * list CF[...][column] should be applicable to normal columns as well as super, for consistency w/ get
> * limit clause doesn't work:
> {code}
> [default@Keyspace1] list CF2['':''] limit 2
> Exception in thread "main" java.lang.AssertionError
> at org.apache.cassandra.cli.CliClient.executeList(CliClient.java:1087)
> at org.apache.cassandra.cli.CliClient.executeCLIStmt(CliClient.java:150)
> at org.apache.cassandra.cli.CliMain.processCLIStmt(CliMain.java:227)
> at org.apache.cassandra.cli.CliMain.main(CliMain.java:300)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-1619) improve cli list command
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-1619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-1619:
--------------------------------------
Attachment: 1619-v3.txt
> improve cli list command
> ------------------------
>
> Key: CASSANDRA-1619
> URL: https://issues.apache.org/jira/browse/CASSANDRA-1619
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 0.7.0
> Reporter: Jonathan Ellis
> Assignee: Jim Ancona
> Fix For: 0.7.0
>
> Attachments: 1619-v2.txt, 1619-v3.txt, cassandra-list-improvements.patch
>
>
> * "list CF" without arguments should assume start_key=end_key=''
> * default limit should be 100, not Integer.MAX_VALUE
> * list CF[...][column] should be applicable to normal columns as well as super, for consistency w/ get
> * limit clause doesn't work:
> {code}
> [default@Keyspace1] list CF2['':''] limit 2
> Exception in thread "main" java.lang.AssertionError
> at org.apache.cassandra.cli.CliClient.executeList(CliClient.java:1087)
> at org.apache.cassandra.cli.CliClient.executeCLIStmt(CliClient.java:150)
> at org.apache.cassandra.cli.CliMain.processCLIStmt(CliMain.java:227)
> at org.apache.cassandra.cli.CliMain.main(CliMain.java:300)
> {code}
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.