You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Mike Percy <mp...@apache.org> on 2016/08/17 17:24:31 UTC

Re: Review Request 50286: FLUME-2318: SpoolingDirectory is unable to handle empty files

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50286/#review146001
-----------------------------------------------------------



This patch looks good to me. It needs a rebase, so I'll do that on commit.

- Mike Percy


On July 21, 2016, 2:16 a.m., Bal�zs Don�t Bessenyei wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50286/
> -----------------------------------------------------------
> 
> (Updated July 21, 2016, 2:16 a.m.)
> 
> 
> Review request for Flume, Denes Arvay and Attila Simon.
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> Empty files should be returned as an empty event instead of no event.
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/src/main/java/org/apache/flume/client/avro/ReliableSpoolingFileEventReader.java 01381a5 
>   flume-ng-core/src/test/java/org/apache/flume/source/TestSpoolDirectorySource.java 82c5351 
> 
> Diff: https://reviews.apache.org/r/50286/diff/
> 
> 
> Testing
> -------
> 
> TestSpoolDirectorySource tests run 12/12 green
> 
> 
> Thanks,
> 
> Bal�zs Don�t Bessenyei
> 
>