You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "ShaunMaher (via GitHub)" <gi...@apache.org> on 2024/11/26 01:48:48 UTC
[PR] PoC fix for #11781, "connect to apisix failed: missing the port number" [apisix]
ShaunMaher opened a new pull request, #11782:
URL: https://github.com/apache/apisix/pull/11782
### Description
Fixes #11781
In the event that `ngx.var.server_port` is a blank string (e.g. client request arrived via unix socket instead of TCP port), `httpc:connect` is given the listening port from the APISIX config, preventing an error.
I have tried to cover the possible ways that node_port can be defined in the config.
`function tab_is_array(t)` borrowed from: https://github.com/apache/apisix/blob/a0b1a4554dc9ce23e877cc1fc58507c795203878/apisix/cli/file.lua#L47
Sorry if my Lua code isn't up to your standards, I'm new to Lua and still finding my feet.
### Checklist
- [X] I have explained the need for this PR and the problem it solves
- [X] I have explained the changes or the new features added to this PR
- [ ] I have added tests corresponding to this change: I'll need help with this
- [ ] I have updated the documentation to reflect this change: I don't think any changes are necessary.
- [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first)
<!--
Note
1. Mark the PR as draft until it's ready to be reviewed.
2. Always add/update tests for any changes unless you have a good reason.
3. Always update the documentation to reflect the changes made in the PR.
4. Make a new commit to resolve conversations instead of `push -f`.
5. To resolve merge conflicts, merge master instead of rebasing.
6. Use "request review" to notify the reviewer after making changes.
7. Only a reviewer can mark a conversation as resolved.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: PoC fix for #11781, "connect to apisix failed: missing the port number" [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #11782:
URL: https://github.com/apache/apisix/pull/11782#issuecomment-2756518602
Hi @ShaunMaher, please add test case and make ci pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: PoC fix for #11781, "connect to apisix failed: missing the port number" [apisix]
Posted by "Baoyuantop (via GitHub)" <gi...@apache.org>.
Baoyuantop commented on PR #11782:
URL: https://github.com/apache/apisix/pull/11782#issuecomment-3125898650
Hi @ShaunMaher, any updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: PoC fix for #11781, "connect to apisix failed: missing the port number" [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #11782: fix: PoC fix for #11781, "connect to apisix failed: missing the port number"
URL: https://github.com/apache/apisix/pull/11782
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: PoC fix for #11781, "connect to apisix failed: missing the port number" [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11782:
URL: https://github.com/apache/apisix/pull/11782#issuecomment-2750763272
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: PoC fix for #11781, "connect to apisix failed: missing the port number" [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11782:
URL: https://github.com/apache/apisix/pull/11782#issuecomment-3337861724
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix: PoC fix for #11781, "connect to apisix failed: missing the port number" [apisix]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #11782:
URL: https://github.com/apache/apisix/pull/11782#issuecomment-3442308443
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org