You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "izveigor (via GitHub)" <gi...@apache.org> on 2023/05/06 19:18:03 UTC

[GitHub] [arrow-rs] izveigor opened a new pull request, #4179: feat: support `Interval` +/- `Interval`

izveigor opened a new pull request, #4179:
URL: https://github.com/apache/arrow-rs/pull/4179

   # Which issue does this PR close?
   
   Closes #4178.
   
   # Rationale for this change
    
   <!--
   Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
   Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
   -->
   
   # What changes are included in this PR?
   
   <!--
   There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
   -->
   
   # Are there any user-facing changes?
   Yes
   
   <!--
   If there are user-facing changes then we may require documentation to be updated before approving the PR.
   -->
   
   <!---
   If there are any breaking changes to public APIs, please add the `breaking change` label.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] izveigor commented on pull request #4179: feat: support `Interval` +/- `Interval`

Posted by "izveigor (via GitHub)" <gi...@apache.org>.
izveigor commented on PR #4179:
URL: https://github.com/apache/arrow-rs/pull/4179#issuecomment-1539558858

   Your argument seems reasonable. "Cast method" gives user more options than "Add method".
   Thanks for your work, @tustvold!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] izveigor closed pull request #4179: feat: support `Interval` +/- `Interval`

Posted by "izveigor (via GitHub)" <gi...@apache.org>.
izveigor closed pull request #4179: feat: support `Interval` +/- `Interval`
URL: https://github.com/apache/arrow-rs/pull/4179


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] izveigor commented on pull request #4179: feat: support `Interval` +/- `Interval`

Posted by "izveigor (via GitHub)" <gi...@apache.org>.
izveigor commented on PR #4179:
URL: https://github.com/apache/arrow-rs/pull/4179#issuecomment-1538950265

   Hello, @tustvold!
   I agree with the fact, that `cast` function can replace `add_dyn` between different types in the same group (like `Int16` + `Int32`).
   But, the `cast` function does not support `Intervals`. See the problem: #4181
   Even if the implementation is done in code, in my opinion, adding different types of intervals can make life easier (for example, if you need to add a day (DayTimeType) to the year (YearMonthType), you get a ready-made type with ready-made calculations, instead of translating two data types into a third (MonthDayNanoType) and producing calculations)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold commented on pull request #4179: feat: support `Interval` +/- `Interval`

Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4179:
URL: https://github.com/apache/arrow-rs/pull/4179#issuecomment-1539046615

   I will try to find time to review https://github.com/apache/arrow-rs/pull/4182 tomorrow, I think this is the best path forward for this, as it avoids the somewhat unclear semantics of heterogenous interval addition, whilst also being less code and more consistent.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org