[GitHub] [arrow-rs] tustvold opened a new issue, #3004: Replace temporal _generic kernels with dyn

[GitBox <gi...@apache.org>]

tustvold opened a new issue, #3004:
URL: https://github.com/apache/arrow-rs/issues/3004

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   <!--
   A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] 
   (This section helps Arrow developers understand the context and *why* for this feature, in addition to  the *what*)
   -->
   
   The temporal _generic methods exist to handle dictionaries, but do so in a way inconsistent with the other kernels such as arithmetic:
   
   * Don't return a dictionary array
   * Require explicitly downcasting the dictionary
   
   **Describe the solution you'd like**
   <!--
   A clear and concise description of what you want to happen.
   -->
   
   Instead of _generic kernels I would like an _dyn kernel that takes an `&dyn Array`.
   
   In the case of a dictionary, this will recurse calling itself on the dictionary values, and then use 
   https://docs.rs/arrow-array/latest/arrow_array/array/struct.DictionaryArray.html#method.with_values to replace the values with the newly computed
   
   **Describe alternatives you've considered**
   <!--
   A clear and concise description of any alternative solutions or features you've considered.
   -->
   
   We could not do this
   
   **Additional context**
   <!--
   Add any other context or screenshots about the feature request here.
   -->
   
   FYI @viirya 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] alamb commented on issue #3004: Replace temporal _generic kernels with dyn

[GitBox <gi...@apache.org>]

alamb commented on issue #3004:
URL: https://github.com/apache/arrow-rs/issues/3004#issuecomment-1312141224

   `label_issue.py` automatically added labels {'arrow'} from #3041


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] tustvold closed issue #3004: Replace temporal _generic kernels with dyn

[GitBox <gi...@apache.org>]

tustvold closed issue #3004: Replace temporal _generic kernels with dyn
URL: https://github.com/apache/arrow-rs/issues/3004


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow-rs] viirya commented on issue #3004: Replace temporal _generic kernels with dyn

[GitBox <gi...@apache.org>]

viirya commented on issue #3004:
URL: https://github.com/apache/arrow-rs/issues/3004#issuecomment-1301207569

   > Don't return a dictionary array
   > Require explicitly downcasting the dictionary
   
   I think that arithmetic kernels don't return a dictionary array for input dictionaries?
   But for temporal kernels, it sounds reasonable to do as the keys should be the same.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org