[jira] [Commented] (AIRFLOW-4455) dag_details broken for subdags in RBAC UI

["James Coder (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4455?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16832490#comment-16832490 ] 

James Coder commented on AIRFLOW-4455:
--------------------------------------

I'm not sure if this is the best solution, but a fix is to change [line 1283|https://github.com/apache/airflow/blob/cec54947d7cf0489284995a6a899b9b94620e301/airflow/models/dag.py#L1283] in models/dag.py from
{code}
orm_dag.fileloc = self.fileloc
{code}
to
{code}
orm_dag.fileloc = self.parent_dag.fileloc if self.is_subdag else self.fileloc
{code}
 

 

> dag_details broken for subdags in RBAC UI
> -----------------------------------------
>
>                 Key: AIRFLOW-4455
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4455
>             Project: Apache Airflow
>          Issue Type: Bug
>          Components: webapp
>    Affects Versions: 1.10.3
>            Reporter: James Coder
>            Priority: Major
>              Labels: regression
>             Fix For: 1.10.4
>
>
> With the release of 1.10.3 dagbag was removed from the dag_details view. This appears to have broken the dag details view for subdags. [line 1484|https://github.com/apache/airflow/blob/cec54947d7cf0489284995a6a899b9b94620e301/airflow/models/dag.py#L1484] in models/Dag.py now uses the dag fileloc to get the dag, however for a subdag, the file loc may not contain the dag if the dag is defined in a function as recommended.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)