You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2019/04/17 17:59:08 UTC
[GitHub] [incubator-pinot] jackjlli commented on a change in pull request
#4130: Add ControllerPeriodicTask integration tests
jackjlli commented on a change in pull request #4130: Add ControllerPeriodicTask integration tests
URL: https://github.com/apache/incubator-pinot/pull/4130#discussion_r276364611
##########
File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/HybridClusterIntegrationTest.java
##########
@@ -301,7 +295,9 @@ public Boolean apply(@Nullable Void aVoid) {
stopServer();
stopBroker();
stopController();
- KafkaStarterUtils.stopServer(_kafkaStarter);
+ for (KafkaServerStartable kafkaStarter : _kafkaStarters) {
Review comment:
Can we wrap this code as `stopKafka()`, just like `startKafka()`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org