You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by "Daniel Nishimura (JIRA)" <ji...@apache.org> on 2018/05/16 19:03:00 UTC

[jira] [Commented] (SAMZA-1717) Move KafkaSystemAdmin.toKafkaSpec logic to a static method in KafkaStreamSpec.

    [ https://issues.apache.org/jira/browse/SAMZA-1717?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16477917#comment-16477917 ] 

Daniel Nishimura commented on SAMZA-1717:
-----------------------------------------

Comment from [~nickpan47]:

Actually, how about having a common interface method toChangelogSpec()/toCheckpointSpec()/toCoordinatorSpec() as general set of methods to StreamSpec and each specific system's implementation class (i.e. KafkaStreamSpec) should implement those methods?

> Move KafkaSystemAdmin.toKafkaSpec logic to a static method in KafkaStreamSpec.
> ------------------------------------------------------------------------------
>
>                 Key: SAMZA-1717
>                 URL: https://issues.apache.org/jira/browse/SAMZA-1717
>             Project: Samza
>          Issue Type: Bug
>            Reporter: Daniel Nishimura
>            Priority: Major
>
> There is some logic in KafkaSystemAdmin.toKafkaSpec that sets properties on the metadata topics. This logic should be part of KafkaStreamSpec.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)