[GitHub] [nifi] bejancsaba commented on a diff in pull request #6587: NIFI-10701 Update MiNiFi docker base images to eclipse-temurin

[GitBox <gi...@apache.org>]

bejancsaba commented on code in PR #6587:
URL: https://github.com/apache/nifi/pull/6587#discussion_r1012720542


##########
minifi/minifi-docker/dockerhub/README.md:
##########
@@ -47,17 +46,17 @@ This can be accomplished through:
 The following example shows the usage of two volumes to provide both a `config.yml` and a `bootstrap.conf` to the container instance.  This makes use of configuration files on the host and maps them to be used by the MiNiFi instance.  This is helpful in scenarios where a single image is used for a variety of configurations.
 
     docker run -d \
-        -v ~/minifi-conf/config.yml:/opt/minifi/minifi-0.5.0/conf/config.yml \
-        -v ~/minifi-conf/bootstrap.conf:/opt/minifi/minifi-0.5.0/conf/bootstrap.conf \
-        apache/nifi-minifi:0.5.0

Review Comment:
   Quite a big jump in versions :)



##########
minifi/minifi-docker/dockerhub/Dockerfile:
##########
@@ -16,13 +16,13 @@
 # under the License.
 #
 
-FROM openjdk:8-jre-alpine
+FROM eclipse-temurin:8-jre

Review Comment:
   I think it is good this way just wanted to double check whether it would make sense to pin the exact version as this way we get the latest and we can get "silent" java updates which could cause problems (at least I faced an issue on a previous project because of this). Again I think we are good and this is how it was earlier just wanted to double check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org