You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@ofbiz.apache.org by ha...@apache.org on 2010/10/29 07:43:06 UTC
svn commit: r1028620 - in /ofbiz/trunk/applications/humanres/data:
HumanResSecurityData.xml HumanResTypeData.xml
Author: hansbak
Date: Fri Oct 29 05:43:05 2010
New Revision: 1028620
URL: http://svn.apache.org/viewvc?rev=1028620&view=rev
Log:
add standard admin group to the HR component
Modified:
ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml
ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
Modified: ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml?rev=1028620&r1=1028619&r2=1028620&view=diff
==============================================================================
--- ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml (original)
+++ ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml Fri Oct 29 05:43:05 2010
@@ -19,6 +19,7 @@ under the License.
-->
<entity-engine-xml>
+ <SecurityPermission description="View operations in the HumanRes Manager." permissionId="HUMANRES_ADMIN"/>
<SecurityPermission description="View operations in the HumanRes Manager." permissionId="HUMANRES_VIEW"/>
<SecurityPermission description="Create operations in the HumanRes Manager." permissionId="HUMANRES_CREATE"/>
<SecurityPermission description="Update operations in the HumanRes Manager." permissionId="HUMANRES_UPDATE"/>
Modified: ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml?rev=1028620&r1=1028619&r2=1028620&view=diff
==============================================================================
--- ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml (original)
+++ ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml Fri Oct 29 05:43:05 2010
@@ -122,12 +122,14 @@ under the License.
<EmplPositionType emplPositionTypeId="_NA_"/>
<!-- OFBiz Recruitment security -->
+ <SecurityGroup groupId="HUMANRES_ADMIN" description="This security group is for those who have full access to the human resource component."/>
<SecurityGroup groupId="HUMANRES_APPROVER" description="This security group is for those who will approve the internal job posting application."/>
<SecurityGroup groupId="HUMANRES_EMPLOYEE" description="This security group is for all the employees who want to apply for internal Job Posting."/>
<!-- Recruitment permission -->
<SecurityPermission description="Approver can update the IJP approval status with this permission." permissionId="HUMANRES_APPROVE"/>
+ <SecurityGroupPermission groupId="HUMANRES_ADMIN" permissionId="HUMANRES_ADMIN"/>
<SecurityGroupPermission groupId="HUMANRES_APPROVER" permissionId="HUMANRES_VIEW"/>
<SecurityGroupPermission groupId="HUMANRES_APPROVER" permissionId="HUMANRES_CREATE"/>
<SecurityGroupPermission groupId="HUMANRES_APPROVER" permissionId="PARTYMGR_VIEW"/>
Re: svn commit: r1028620 - in /ofbiz/trunk/applications/humanres/data:
HumanResSecurityData.xml HumanResTypeData.xml
Posted by David E Jones <de...@me.com>.
Perhaps there is some confusion due to insufficient details...
Hans did you look at the line Adrian is referring to, namely:
>>> +<SecurityPermission description="View operations in the HumanRes Manager." permissionId="HUMANRES_ADMIN"/>
The description is simply not consistent with the ID of the permission or how it is used.
-David
On Oct 29, 2010, at 8:44 AM, Adrian Crum wrote:
> It's your commit, and I have no problem if you change it.
>
> -Adrian
>
> On 10/29/2010 7:39 AM, Hans Bakker wrote:
>> Adrian, I have no problem if you change the description, if you think
>> that is better.
>>
>> Regards,
>> Hans
>>
>> On Fri, 2010-10-29 at 07:24 -0700, Adrian Crum wrote:
>>> Shouldn't the SecurityPermission description be
>>>
>>> "ALL operations in the HumanRes Manager."
>>>
>>> ?
>>>
>>> -Adrian
>>>
>>> On 10/28/2010 10:43 PM, hansbak@apache.org wrote:
>>>> Author: hansbak
>>>> Date: Fri Oct 29 05:43:05 2010
>>>> New Revision: 1028620
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1028620&view=rev
>>>> Log:
>>>> add standard admin group to the HR component
>>>>
>>>> Modified:
>>>> ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml
>>>> ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
>>>>
>>>> Modified: ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml
>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml?rev=1028620&r1=1028619&r2=1028620&view=diff
>>>> ==============================================================================
>>>> --- ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml (original)
>>>> +++ ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml Fri Oct 29 05:43:05 2010
>>>> @@ -19,6 +19,7 @@ under the License.
>>>> -->
>>>>
>>>> <entity-engine-xml>
>>>> +<SecurityPermission description="View operations in the HumanRes Manager." permissionId="HUMANRES_ADMIN"/>
>>>> <SecurityPermission description="View operations in the HumanRes Manager." permissionId="HUMANRES_VIEW"/>
>>>> <SecurityPermission description="Create operations in the HumanRes Manager." permissionId="HUMANRES_CREATE"/>
>>>> <SecurityPermission description="Update operations in the HumanRes Manager." permissionId="HUMANRES_UPDATE"/>
>>>>
>>>> Modified: ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
>>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml?rev=1028620&r1=1028619&r2=1028620&view=diff
>>>> ==============================================================================
>>>> --- ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml (original)
>>>> +++ ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml Fri Oct 29 05:43:05 2010
>>>> @@ -122,12 +122,14 @@ under the License.
>>>> <EmplPositionType emplPositionTypeId="_NA_"/>
>>>>
>>>> <!-- OFBiz Recruitment security -->
>>>> +<SecurityGroup groupId="HUMANRES_ADMIN" description="This security group is for those who have full access to the human resource component."/>
>>>> <SecurityGroup groupId="HUMANRES_APPROVER" description="This security group is for those who will approve the internal job posting application."/>
>>>> <SecurityGroup groupId="HUMANRES_EMPLOYEE" description="This security group is for all the employees who want to apply for internal Job Posting."/>
>>>>
>>>> <!-- Recruitment permission -->
>>>> <SecurityPermission description="Approver can update the IJP approval status with this permission." permissionId="HUMANRES_APPROVE"/>
>>>>
>>>> +<SecurityGroupPermission groupId="HUMANRES_ADMIN" permissionId="HUMANRES_ADMIN"/>
>>>> <SecurityGroupPermission groupId="HUMANRES_APPROVER" permissionId="HUMANRES_VIEW"/>
>>>> <SecurityGroupPermission groupId="HUMANRES_APPROVER" permissionId="HUMANRES_CREATE"/>
>>>> <SecurityGroupPermission groupId="HUMANRES_APPROVER" permissionId="PARTYMGR_VIEW"/>
>>>>
>>>>
>>>>
>>
Re: svn commit: r1028620 - in /ofbiz/trunk/applications/humanres/data:
HumanResSecurityData.xml HumanResTypeData.xml
Posted by Adrian Crum <ad...@hlmksw.com>.
It's your commit, and I have no problem if you change it.
-Adrian
On 10/29/2010 7:39 AM, Hans Bakker wrote:
> Adrian, I have no problem if you change the description, if you think
> that is better.
>
> Regards,
> Hans
>
> On Fri, 2010-10-29 at 07:24 -0700, Adrian Crum wrote:
>> Shouldn't the SecurityPermission description be
>>
>> "ALL operations in the HumanRes Manager."
>>
>> ?
>>
>> -Adrian
>>
>> On 10/28/2010 10:43 PM, hansbak@apache.org wrote:
>>> Author: hansbak
>>> Date: Fri Oct 29 05:43:05 2010
>>> New Revision: 1028620
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1028620&view=rev
>>> Log:
>>> add standard admin group to the HR component
>>>
>>> Modified:
>>> ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml
>>> ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
>>>
>>> Modified: ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml?rev=1028620&r1=1028619&r2=1028620&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml (original)
>>> +++ ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml Fri Oct 29 05:43:05 2010
>>> @@ -19,6 +19,7 @@ under the License.
>>> -->
>>>
>>> <entity-engine-xml>
>>> +<SecurityPermission description="View operations in the HumanRes Manager." permissionId="HUMANRES_ADMIN"/>
>>> <SecurityPermission description="View operations in the HumanRes Manager." permissionId="HUMANRES_VIEW"/>
>>> <SecurityPermission description="Create operations in the HumanRes Manager." permissionId="HUMANRES_CREATE"/>
>>> <SecurityPermission description="Update operations in the HumanRes Manager." permissionId="HUMANRES_UPDATE"/>
>>>
>>> Modified: ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
>>> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml?rev=1028620&r1=1028619&r2=1028620&view=diff
>>> ==============================================================================
>>> --- ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml (original)
>>> +++ ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml Fri Oct 29 05:43:05 2010
>>> @@ -122,12 +122,14 @@ under the License.
>>> <EmplPositionType emplPositionTypeId="_NA_"/>
>>>
>>> <!-- OFBiz Recruitment security -->
>>> +<SecurityGroup groupId="HUMANRES_ADMIN" description="This security group is for those who have full access to the human resource component."/>
>>> <SecurityGroup groupId="HUMANRES_APPROVER" description="This security group is for those who will approve the internal job posting application."/>
>>> <SecurityGroup groupId="HUMANRES_EMPLOYEE" description="This security group is for all the employees who want to apply for internal Job Posting."/>
>>>
>>> <!-- Recruitment permission -->
>>> <SecurityPermission description="Approver can update the IJP approval status with this permission." permissionId="HUMANRES_APPROVE"/>
>>>
>>> +<SecurityGroupPermission groupId="HUMANRES_ADMIN" permissionId="HUMANRES_ADMIN"/>
>>> <SecurityGroupPermission groupId="HUMANRES_APPROVER" permissionId="HUMANRES_VIEW"/>
>>> <SecurityGroupPermission groupId="HUMANRES_APPROVER" permissionId="HUMANRES_CREATE"/>
>>> <SecurityGroupPermission groupId="HUMANRES_APPROVER" permissionId="PARTYMGR_VIEW"/>
>>>
>>>
>>>
>
Re: svn commit: r1028620 - in
/ofbiz/trunk/applications/humanres/data: HumanResSecurityData.xml
HumanResTypeData.xml
Posted by Hans Bakker <ma...@antwebsystems.com>.
Adrian, I have no problem if you change the description, if you think
that is better.
Regards,
Hans
On Fri, 2010-10-29 at 07:24 -0700, Adrian Crum wrote:
> Shouldn't the SecurityPermission description be
>
> "ALL operations in the HumanRes Manager."
>
> ?
>
> -Adrian
>
> On 10/28/2010 10:43 PM, hansbak@apache.org wrote:
> > Author: hansbak
> > Date: Fri Oct 29 05:43:05 2010
> > New Revision: 1028620
> >
> > URL: http://svn.apache.org/viewvc?rev=1028620&view=rev
> > Log:
> > add standard admin group to the HR component
> >
> > Modified:
> > ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml
> > ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
> >
> > Modified: ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml?rev=1028620&r1=1028619&r2=1028620&view=diff
> > ==============================================================================
> > --- ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml (original)
> > +++ ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml Fri Oct 29 05:43:05 2010
> > @@ -19,6 +19,7 @@ under the License.
> > -->
> >
> > <entity-engine-xml>
> > +<SecurityPermission description="View operations in the HumanRes Manager." permissionId="HUMANRES_ADMIN"/>
> > <SecurityPermission description="View operations in the HumanRes Manager." permissionId="HUMANRES_VIEW"/>
> > <SecurityPermission description="Create operations in the HumanRes Manager." permissionId="HUMANRES_CREATE"/>
> > <SecurityPermission description="Update operations in the HumanRes Manager." permissionId="HUMANRES_UPDATE"/>
> >
> > Modified: ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
> > URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml?rev=1028620&r1=1028619&r2=1028620&view=diff
> > ==============================================================================
> > --- ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml (original)
> > +++ ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml Fri Oct 29 05:43:05 2010
> > @@ -122,12 +122,14 @@ under the License.
> > <EmplPositionType emplPositionTypeId="_NA_"/>
> >
> > <!-- OFBiz Recruitment security -->
> > +<SecurityGroup groupId="HUMANRES_ADMIN" description="This security group is for those who have full access to the human resource component."/>
> > <SecurityGroup groupId="HUMANRES_APPROVER" description="This security group is for those who will approve the internal job posting application."/>
> > <SecurityGroup groupId="HUMANRES_EMPLOYEE" description="This security group is for all the employees who want to apply for internal Job Posting."/>
> >
> > <!-- Recruitment permission -->
> > <SecurityPermission description="Approver can update the IJP approval status with this permission." permissionId="HUMANRES_APPROVE"/>
> >
> > +<SecurityGroupPermission groupId="HUMANRES_ADMIN" permissionId="HUMANRES_ADMIN"/>
> > <SecurityGroupPermission groupId="HUMANRES_APPROVER" permissionId="HUMANRES_VIEW"/>
> > <SecurityGroupPermission groupId="HUMANRES_APPROVER" permissionId="HUMANRES_CREATE"/>
> > <SecurityGroupPermission groupId="HUMANRES_APPROVER" permissionId="PARTYMGR_VIEW"/>
> >
> >
> >
--
Ofbiz on twitter: http://twitter.com/apache_ofbiz
Myself on twitter: http://twitter.com/hansbak
Antwebsystems.com: Quality services for competitive rates.
Re: svn commit: r1028620 - in /ofbiz/trunk/applications/humanres/data:
HumanResSecurityData.xml HumanResTypeData.xml
Posted by Adrian Crum <ad...@hlmksw.com>.
Shouldn't the SecurityPermission description be
"ALL operations in the HumanRes Manager."
?
-Adrian
On 10/28/2010 10:43 PM, hansbak@apache.org wrote:
> Author: hansbak
> Date: Fri Oct 29 05:43:05 2010
> New Revision: 1028620
>
> URL: http://svn.apache.org/viewvc?rev=1028620&view=rev
> Log:
> add standard admin group to the HR component
>
> Modified:
> ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml
> ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
>
> Modified: ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml?rev=1028620&r1=1028619&r2=1028620&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml (original)
> +++ ofbiz/trunk/applications/humanres/data/HumanResSecurityData.xml Fri Oct 29 05:43:05 2010
> @@ -19,6 +19,7 @@ under the License.
> -->
>
> <entity-engine-xml>
> +<SecurityPermission description="View operations in the HumanRes Manager." permissionId="HUMANRES_ADMIN"/>
> <SecurityPermission description="View operations in the HumanRes Manager." permissionId="HUMANRES_VIEW"/>
> <SecurityPermission description="Create operations in the HumanRes Manager." permissionId="HUMANRES_CREATE"/>
> <SecurityPermission description="Update operations in the HumanRes Manager." permissionId="HUMANRES_UPDATE"/>
>
> Modified: ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml?rev=1028620&r1=1028619&r2=1028620&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml (original)
> +++ ofbiz/trunk/applications/humanres/data/HumanResTypeData.xml Fri Oct 29 05:43:05 2010
> @@ -122,12 +122,14 @@ under the License.
> <EmplPositionType emplPositionTypeId="_NA_"/>
>
> <!-- OFBiz Recruitment security -->
> +<SecurityGroup groupId="HUMANRES_ADMIN" description="This security group is for those who have full access to the human resource component."/>
> <SecurityGroup groupId="HUMANRES_APPROVER" description="This security group is for those who will approve the internal job posting application."/>
> <SecurityGroup groupId="HUMANRES_EMPLOYEE" description="This security group is for all the employees who want to apply for internal Job Posting."/>
>
> <!-- Recruitment permission -->
> <SecurityPermission description="Approver can update the IJP approval status with this permission." permissionId="HUMANRES_APPROVE"/>
>
> +<SecurityGroupPermission groupId="HUMANRES_ADMIN" permissionId="HUMANRES_ADMIN"/>
> <SecurityGroupPermission groupId="HUMANRES_APPROVER" permissionId="HUMANRES_VIEW"/>
> <SecurityGroupPermission groupId="HUMANRES_APPROVER" permissionId="HUMANRES_CREATE"/>
> <SecurityGroupPermission groupId="HUMANRES_APPROVER" permissionId="PARTYMGR_VIEW"/>
>
>
>