You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by "wzhallright (via GitHub)" <gi...@apache.org> on 2023/05/19 07:44:49 UTC

[GitHub] [ratis] wzhallright opened a new pull request, #882: RATIS-1844. Remove unused rpcType in SupportedRpcType

wzhallright opened a new pull request, #882:
URL: https://github.com/apache/ratis/pull/882

   ## What changes were proposed in this pull request?
   
   Remove unused rpcType 
   
   ## What is the link to the Apache JIRA
   
   [RATIS-1844](https://issues.apache.org/jira/browse/RATIS-1844)
   
   
   ## How was this patch tested?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] wzhallright commented on a diff in pull request #882: RATIS-1844. Remove unused rpcType in SupportedRpcType

Posted by "wzhallright (via GitHub)" <gi...@apache.org>.
wzhallright commented on code in PR #882:
URL: https://github.com/apache/ratis/pull/882#discussion_r1198658640


##########
ratis-common/src/main/java/org/apache/ratis/rpc/SupportedRpcType.java:
##########
@@ -23,8 +23,7 @@
 /** The RPC types supported. */
 public enum SupportedRpcType implements RpcType {
   NETTY("org.apache.ratis.netty.NettyFactory"),
-  GRPC("org.apache.ratis.grpc.GrpcFactory"),
-  HADOOP("org.apache.ratis.hadooprpc.HadoopFactory");

Review Comment:
   oh, sorry!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] szetszwo commented on a diff in pull request #882: RATIS-1844. Remove unused rpcType in SupportedRpcType

Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on code in PR #882:
URL: https://github.com/apache/ratis/pull/882#discussion_r1198654780


##########
ratis-common/src/main/java/org/apache/ratis/rpc/SupportedRpcType.java:
##########
@@ -23,8 +23,7 @@
 /** The RPC types supported. */
 public enum SupportedRpcType implements RpcType {
   NETTY("org.apache.ratis.netty.NettyFactory"),
-  GRPC("org.apache.ratis.grpc.GrpcFactory"),
-  HADOOP("org.apache.ratis.hadooprpc.HadoopFactory");

Review Comment:
   This is used in https://github.com/apache/ratis-hadoop-projects/ .  Let's don't remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] wzhallright closed pull request #882: RATIS-1844. Remove unused rpcType in SupportedRpcType

Posted by "wzhallright (via GitHub)" <gi...@apache.org>.
wzhallright closed pull request #882: RATIS-1844. Remove unused rpcType in SupportedRpcType
URL: https://github.com/apache/ratis/pull/882


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [ratis] szetszwo commented on a diff in pull request #882: RATIS-1844. Remove unused rpcType in SupportedRpcType

Posted by "szetszwo (via GitHub)" <gi...@apache.org>.
szetszwo commented on code in PR #882:
URL: https://github.com/apache/ratis/pull/882#discussion_r1199430453


##########
ratis-common/src/main/java/org/apache/ratis/rpc/SupportedRpcType.java:
##########
@@ -23,8 +23,7 @@
 /** The RPC types supported. */
 public enum SupportedRpcType implements RpcType {
   NETTY("org.apache.ratis.netty.NettyFactory"),
-  GRPC("org.apache.ratis.grpc.GrpcFactory"),
-  HADOOP("org.apache.ratis.hadooprpc.HadoopFactory");

Review Comment:
   No problem.  Thanks for checking it!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ratis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org