[GitHub] [avro] kojiromike commented on a change in pull request #933: AVRO-2892: Isolate Errors to Simplify Import Graph

[GitBox <gi...@apache.org>]

kojiromike commented on a change in pull request #933:
URL: https://github.com/apache/avro/pull/933#discussion_r467216600



##########
File path: lang/py/avro/schema.py
##########
@@ -1120,22 +1100,25 @@ def make_avsc_object(json_data, names=None, validate_enum_symbols=True):
     # not for us!
     else:
         fail_msg = "Could not make an Avro Schema object from %s." % json_data
-        raise SchemaParseException(fail_msg)
+        raise avro.errors.SchemaParseException(fail_msg)
 
 # TODO(hammer): make method for reading from a file?
 
 
-def parse(json_string, validate_enum_symbols=True):
+def parse(json_string, validate_enum_symbols=True, register_codec=None):
     """Constructs the Schema from the JSON text.
 
+    @arg json_string: The json string of the schema to parse
     @arg validate_enum_symbols: If False, will allow enum symbols that are not valid Avro names.
+    @arg register_codec: If a string, registers a Python codec by that name.

Review comment:
       hah no, good catch




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org