You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/06/08 09:27:30 UTC
[GitHub] [incubator-doris] zxealous opened a new pull request, #10017: [style] Fix the code style defined by class member variables in query…
zxealous opened a new pull request, #10017:
URL: https://github.com/apache/incubator-doris/pull/10017
…_statistics
# Proposed changes
fix code style in QueryStatistics
## Problem Summary:
The definition of class member variables in Doris BE usually starts with an underscore, but in the two classes NodeStatistics and QueryStatistics, class member variables are not defined in this form. Should this be modified to this form?
## Checklist(Required)
1. Does it affect the original behavior: (No)
2. Has unit tests been added: (No)
3. Has document been added or modified: (No)
4. Does it need to update dependencies: (No)
5. Are there any changes that cannot be rolled back: (No)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] zxealous commented on pull request #10017: [style] Fix the code style defined by class member variables in query…
Posted by GitBox <gi...@apache.org>.
zxealous commented on PR #10017:
URL: https://github.com/apache/incubator-doris/pull/10017#issuecomment-1150728132
@morningman Can this pr be merged?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zxealous closed pull request #10017: [style] Fix the code style defined by class member variables in query…
Posted by GitBox <gi...@apache.org>.
zxealous closed pull request #10017: [style] Fix the code style defined by class member variables in query…
URL: https://github.com/apache/doris/pull/10017
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org