You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2019/10/17 18:35:54 UTC
[kudu-CR](branch-1.11.x) [hms] Fix TestKuduMetastorePlugin on Hive 4
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14489
Change subject: [hms] Fix TestKuduMetastorePlugin on Hive 4
......................................................................
[hms] Fix TestKuduMetastorePlugin on Hive 4
This patch is another patch in preparation for Hive 3 and 4.
In Hive 4 the MetastoreDefaultTransformer ensures that
external tables don’t use the warehouse as a their storage location.
Kudu doesn’t actually use this location, but the location must still be
valid.
This patch changes the test to set the correct location for external
and managed tables and configures a default external warehouse
for Hive 4+.
Change-Id: Ia211e65f66ce6002e6d25b31ab88437630e19473
Reviewed-on: http://gerrit.cloudera.org:8080/14487
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao <ha...@cloudera.com>
(cherry picked from commit d96f8fca55222da2a8a9e4c98bf4bebee3525989)
---
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
1 file changed, 30 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/14489/1
--
To view, visit http://gerrit.cloudera.org:8080/14489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia211e65f66ce6002e6d25b31ab88437630e19473
Gerrit-Change-Number: 14489
Gerrit-PatchSet: 1
Gerrit-Owner: Grant Henke <gr...@apache.org>
[kudu-CR](branch-1.11.x) [hms] Fix TestKuduMetastorePlugin on Hive 4
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/14489 )
Change subject: [hms] Fix TestKuduMetastorePlugin on Hive 4
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia211e65f66ce6002e6d25b31ab88437630e19473
Gerrit-Change-Number: 14489
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 22:29:04 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.11.x) [hms] Fix TestKuduMetastorePlugin on Hive 4
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14489 )
Change subject: [hms] Fix TestKuduMetastorePlugin on Hive 4
......................................................................
[hms] Fix TestKuduMetastorePlugin on Hive 4
This patch is another patch in preparation for Hive 3 and 4.
In Hive 4 the MetastoreDefaultTransformer ensures that
external tables don’t use the warehouse as a their storage location.
Kudu doesn’t actually use this location, but the location must still be
valid.
This patch changes the test to set the correct location for external
and managed tables and configures a default external warehouse
for Hive 4+.
Change-Id: Ia211e65f66ce6002e6d25b31ab88437630e19473
Reviewed-on: http://gerrit.cloudera.org:8080/14487
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao <ha...@cloudera.com>
(cherry picked from commit d96f8fca55222da2a8a9e4c98bf4bebee3525989)
Reviewed-on: http://gerrit.cloudera.org:8080/14489
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Grant Henke <gr...@apache.org>
---
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
1 file changed, 30 insertions(+), 5 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Hao Hao: Looks good to me, approved
Grant Henke: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia211e65f66ce6002e6d25b31ab88437630e19473
Gerrit-Change-Number: 14489
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.11.x) [hms] Fix TestKuduMetastorePlugin on Hive 4
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has uploaded a new patch set (#2) to the change originally created by Grant Henke. ( http://gerrit.cloudera.org:8080/14489 )
Change subject: [hms] Fix TestKuduMetastorePlugin on Hive 4
......................................................................
[hms] Fix TestKuduMetastorePlugin on Hive 4
This patch is another patch in preparation for Hive 3 and 4.
In Hive 4 the MetastoreDefaultTransformer ensures that
external tables don’t use the warehouse as a their storage location.
Kudu doesn’t actually use this location, but the location must still be
valid.
This patch changes the test to set the correct location for external
and managed tables and configures a default external warehouse
for Hive 4+.
Change-Id: Ia211e65f66ce6002e6d25b31ab88437630e19473
Reviewed-on: http://gerrit.cloudera.org:8080/14487
Tested-by: Kudu Jenkins
Reviewed-by: Hao Hao <ha...@cloudera.com>
(cherry picked from commit d96f8fca55222da2a8a9e4c98bf4bebee3525989)
---
M java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java
1 file changed, 30 insertions(+), 5 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/14489/2
--
To view, visit http://gerrit.cloudera.org:8080/14489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ia211e65f66ce6002e6d25b31ab88437630e19473
Gerrit-Change-Number: 14489
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR](branch-1.11.x) [hms] Fix TestKuduMetastorePlugin on Hive 4
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/14489 )
Change subject: [hms] Fix TestKuduMetastorePlugin on Hive 4
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia211e65f66ce6002e6d25b31ab88437630e19473
Gerrit-Change-Number: 14489
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 21:21:35 +0000
Gerrit-HasComments: No
[kudu-CR](branch-1.11.x) [hms] Fix TestKuduMetastorePlugin on Hive 4
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14489 )
Change subject: [hms] Fix TestKuduMetastorePlugin on Hive 4
......................................................................
Patch Set 2: Code-Review+2
whoops, it seem I unintentionally re-based it
--
To view, visit http://gerrit.cloudera.org:8080/14489
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.11.x
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia211e65f66ce6002e6d25b31ab88437630e19473
Gerrit-Change-Number: 14489
Gerrit-PatchSet: 2
Gerrit-Owner: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 17 Oct 2019 19:27:34 +0000
Gerrit-HasComments: No